From 700585d0de3f99e08a91066376361ca7626fa1f3 Mon Sep 17 00:00:00 2001 From: a-kuroki-gs Date: Wed, 7 Feb 2024 09:50:57 +0900 Subject: [PATCH 1/5] =?UTF-8?q?Markdown=E3=81=AE=E8=A8=98=E6=B3=95?= =?UTF-8?q?=E3=81=A7=E3=83=A6=E3=83=BC=E3=82=B6=E3=83=BC=E3=82=A2=E3=82=A4?= =?UTF-8?q?=E3=82=B3=E3=83=B3=E3=82=92=E8=A1=A8=E7=A4=BA=E3=81=99=E3=82=8B?= =?UTF-8?q?=E7=AE=87=E6=89=80=E3=81=AB=E3=81=8A=E3=81=84=E3=81=A6title?= =?UTF-8?q?=E5=B1=9E=E6=80=A7=E3=82=92=E8=BF=BD=E5=8A=A0?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit hover時にユーザー名の文字列を表示するようにするため --- app/javascript/markdown-it-user-icon.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/javascript/markdown-it-user-icon.js b/app/javascript/markdown-it-user-icon.js index cd245115bf6..b827ceeabe2 100644 --- a/app/javascript/markdown-it-user-icon.js +++ b/app/javascript/markdown-it-user-icon.js @@ -4,6 +4,6 @@ export default MarkdownItRegexp( /:@(?!mentor:)([a-zA-Z0-9_-]+):/, (match) => { - return `` + return `` } ) From 172eada29bc06492631cbf4fdfd58eb419b7cb14 Mon Sep 17 00:00:00 2001 From: a-kuroki-gs Date: Wed, 7 Feb 2024 11:53:49 +0900 Subject: [PATCH 2/5] =?UTF-8?q?title=E5=B1=9E=E6=80=A7=E3=82=92=E6=A4=9C?= =?UTF-8?q?=E8=A8=BC=E3=81=99=E3=82=8B=E3=83=86=E3=82=B9=E3=83=88=E3=82=92?= =?UTF-8?q?=E8=BF=BD=E5=8A=A0?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- test/system/markdown_test.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/test/system/markdown_test.rb b/test/system/markdown_test.rb index 13f549fef30..f5d6fdf86e8 100644 --- a/test/system/markdown_test.rb +++ b/test/system/markdown_test.rb @@ -25,6 +25,7 @@ class MarkdownTest < ApplicationSystemTestCase assert_css '.a-long-text.is-md.js-markdown-view' assert_css "a[href='/users/mentormentaro']" + assert_includes find('.js-user-icon.a-user-emoji')['title'], '@mentormentaro' assert_includes find('.js-user-icon.a-user-emoji')['data-user'], 'mentormentaro' end From 84f623f72a5d44ac6f595899475e2ce39654b4ff Mon Sep 17 00:00:00 2001 From: a-kuroki-gs Date: Wed, 7 Feb 2024 16:58:31 +0900 Subject: [PATCH 3/5] =?UTF-8?q?=E3=82=A4=E3=83=B3=E3=82=BF=E3=83=93?= =?UTF-8?q?=E3=83=A5=E3=83=BC=E3=83=96=E3=83=AD=E3=83=83=E3=82=AF=E3=81=A7?= =?UTF-8?q?=E3=83=A6=E3=83=BC=E3=82=B6=E3=83=BC=E3=82=A2=E3=82=A4=E3=82=B3?= =?UTF-8?q?=E3=83=B3=E3=82=92=E8=A1=A8=E7=A4=BA=E3=81=99=E3=82=8B=E7=AE=87?= =?UTF-8?q?=E6=89=80=E3=81=AB=E3=81=8A=E3=81=84=E3=81=A6title=E5=B1=9E?= =?UTF-8?q?=E6=80=A7=E3=82=92=E8=BF=BD=E5=8A=A0?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit hover時にユーザー名の文字列を表示するようにするため --- app/javascript/markdown-it-container-speak.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/javascript/markdown-it-container-speak.js b/app/javascript/markdown-it-container-speak.js index 6814504e072..b0bd344f575 100644 --- a/app/javascript/markdown-it-container-speak.js +++ b/app/javascript/markdown-it-container-speak.js @@ -11,7 +11,7 @@ export default (md) => { return `
- + ${speakerName}
From c93cd46482f6a66c4b5e9c7a07395399220ec93d Mon Sep 17 00:00:00 2001 From: a-kuroki-gs Date: Wed, 7 Feb 2024 17:01:15 +0900 Subject: [PATCH 4/5] =?UTF-8?q?=E3=82=A4=E3=83=B3=E3=82=BF=E3=83=93?= =?UTF-8?q?=E3=83=A5=E3=83=BC=E3=83=96=E3=83=AD=E3=83=83=E3=82=AF=E7=94=A8?= =?UTF-8?q?=E3=81=AE=E3=83=86=E3=82=B9=E3=83=88=E3=82=92=E8=BF=BD=E5=8A=A0?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- test/system/markdown_test.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/test/system/markdown_test.rb b/test/system/markdown_test.rb index f5d6fdf86e8..ad01101fea4 100644 --- a/test/system/markdown_test.rb +++ b/test/system/markdown_test.rb @@ -13,6 +13,7 @@ class MarkdownTest < ApplicationSystemTestCase assert_css '.a-long-text.is-md.js-markdown-view' assert_css '.speak' assert_css "a[href='/users/mentormentaro']" + assert_includes find('.js-user-icon.a-user-emoji')['title'], '@mentormentaro' assert_includes find('.js-user-icon.a-user-emoji')['data-user'], 'mentormentaro' end From 37cc341c5c7c3e6c3de06103119da17da9bfe302 Mon Sep 17 00:00:00 2001 From: a-kuroki-gs Date: Mon, 19 Feb 2024 14:11:59 +0900 Subject: [PATCH 5/5] =?UTF-8?q?=E3=83=86=E3=82=B9=E3=83=88=E3=81=AE?= =?UTF-8?q?=E4=B8=80=E9=83=A8=E3=82=92DRY=E3=81=AA=E3=82=B3=E3=83=BC?= =?UTF-8?q?=E3=83=89=E3=81=AB=E4=BF=AE=E6=AD=A3?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- test/system/markdown_test.rb | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/test/system/markdown_test.rb b/test/system/markdown_test.rb index ad01101fea4..4336c54276b 100644 --- a/test/system/markdown_test.rb +++ b/test/system/markdown_test.rb @@ -13,8 +13,9 @@ class MarkdownTest < ApplicationSystemTestCase assert_css '.a-long-text.is-md.js-markdown-view' assert_css '.speak' assert_css "a[href='/users/mentormentaro']" - assert_includes find('.js-user-icon.a-user-emoji')['title'], '@mentormentaro' - assert_includes find('.js-user-icon.a-user-emoji')['data-user'], 'mentormentaro' + emoji = find('.js-user-icon.a-user-emoji') + assert_includes emoji['title'], '@mentormentaro' + assert_includes emoji['data-user'], 'mentormentaro' end test 'user profile image markdown test' do @@ -26,8 +27,9 @@ class MarkdownTest < ApplicationSystemTestCase assert_css '.a-long-text.is-md.js-markdown-view' assert_css "a[href='/users/mentormentaro']" - assert_includes find('.js-user-icon.a-user-emoji')['title'], '@mentormentaro' - assert_includes find('.js-user-icon.a-user-emoji')['data-user'], 'mentormentaro' + emoji = find('.js-user-icon.a-user-emoji') + assert_includes emoji['title'], '@mentormentaro' + assert_includes emoji['data-user'], 'mentormentaro' end def cmd_ctrl