Review class Util.dart and Flame.dart #623
Locked
erickzanardo
started this conversation in
Ideas
Replies: 1 comment
-
Solved by #640 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
Our Util.dart has a bunch of methods that could be moved, or some even removed, here I will list all the reviews that I think that we could do:
fullScreen
,setOrientation
and all methods related to screen orientation could be elsewhere, like a device.dart or something like that.initialDimensions
: I am almost sure that this method can be deleted, because of the GameWidget we have a better way to get the game size and this method can cause a lot of confusingremoveGestureRecognizer
can be removed as we have a better way of handling gesture nowAbout Flame.dart
init
method could be on the same device.dart file mentioned aboveBeta Was this translation helpful? Give feedback.
All reactions