-
Notifications
You must be signed in to change notification settings - Fork 1
Chief Delphi 2020 Code Review Party #3
Comments
As is expected, with 10 weeks to be able to code, there's not a lot of error or improvements in logic. In fact, the sequencing is quite logical. A pro of using Command Based programming. However, the pitfall of Command Based is having too many files. Going through every tree, this year's code has 85 files inside robot2020. I think that's rather ridiculous, but that's coming from a Timed Robot guy with only 10 files. And then I decided to head over and check out 254's 2019 code, and holy cow! I'm not going to bother counting how many files there are! Anyways, I didn't have much to work with based on what you submitted in the CD Google Form. Nothing special I should notice, nothing I should look out for. I did what I could. If there are any questions, reply to the issue and I'll get back within 3 days. In General:
That cleans up all I have to say. If I have free time the rest of spring, I might keep looking over the code, but I doubt it. If you've had enough of me, close the issue and I won't bother your team anymore. I hope this helped you even marginally, and good luck from here on out! |
Thanks for the feedback! With all the craziness of quarantine I missed this, so apologies for the late reply. We really appreciate the feedback and will definitely take it into consideration for the upcoming season. Best of luck to you and your team! |
Hello! I am Christopher Marley, a co-lead programmer of FRC Team 4681, Murphy's Law, and I have been assigned your repository as part of the Chief Delphi "2020 Code Review Party". Over the next two weeks, I will be plumbing the depths of your code and compiling everything in this one issue (so your emails aren't 'pinged' too much).
Quick disclaimer, our team uses
TimedRobot
, so forgive me if my knowledge of command based is lacking. I did do a lot of research on the features, so I should be up to speed.If you have any questions at all, reply to this issue or directly email me at [email protected].
I'm very surprised there have been no issues opened in this repo... cool!
The text was updated successfully, but these errors were encountered: