Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: option to use "collapse" or "accordion" #45

Closed
mattez opened this issue Aug 14, 2015 · 3 comments · May be fixed by #46
Closed

Feature: option to use "collapse" or "accordion" #45

mattez opened this issue Aug 14, 2015 · 3 comments · May be fixed by #46

Comments

@mattez
Copy link

mattez commented Aug 14, 2015

Accordion is cool but I need only basic "collapse" functionality. => Panels keep opened, not auto collapsed, more panels can be opened at the same time.

Difference is only in specifying "data-parent" attribute. If it is specified it behaves as accordion, if not is simple collapse.
In actual version, it is on line 106:

'data-parent': '#' + parentId,

It would be nice to specify this in options. Something like

$( "#nav-tabs--fleet" ).tabCollapse( {
    accordion: true
} );
if(this.options.accordion){
    'data-parent': '#' + parentId,
}

It would be helpful.
Or there is some another workaround?
@mattez
Copy link
Author

mattez commented Aug 14, 2015

Generally: this library is called "tabcollapse" not "tabaccordion". So in first place, it should behave like simple collapse and accordion should extend the default collapse behavior.

@mattez mattez mentioned this issue Aug 14, 2015
Open
@mattez
Copy link
Author

mattez commented Aug 14, 2015

I created a pull request with basic implementation of this feature.

@mattez mattez mentioned this issue Aug 14, 2015
Closed
@geoffrey-eisenbarth
Copy link

This is what I needed too, thanks for doing the legwork. Wish the pull would be accepted :(

@erik0002 erik0002 closed this as completed Jul 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add option.accordion (if false panels behave as basic collapse) mattez/bootstrap-tabcollapse
3 participants
@mattez @geoffrey-eisenbarth @erik0002