Some tests are gtk2 only

[HinTak]

ScrollingTest for example. I have both gtk2 and gtk3, and found that I needed to change $EXTRA_LIBS and $EXTRA_CFLAGS from GTK_* to GTK2_* in test to let it finish building.

[HinTak]

I have a local fix as outlined above, but I assume the correct change is possibly trying to make the test work with both, instead of limiting to gtk2

[flatmax]

I think this bug is most likely showing itself due to Distro upgrades defaulting to gtk3 ... its taken them a while.
Yep agreed, the headers have to be altered for specific classes to update them to be compat. with gtk3.
Another fix would be to put versioning #ifdef s in the effected files and in the test Makefile.am.

[HinTak]

Fedora has been gtk3 for quite a few years; Ubuntu is largely gtk3 for a couple of years now. You actually had one place in code , "include/Selection.H" where you check and error on gtk3. At least any file including that is meant to be gtk2 only. In the end I did the quick fix, which is changing "test/Makefile.am" around line 47, just after JackPortMonitorGuiTest/TimeTest to do GTK2 - which includes ScrollingTest - but maybe some of those work with gtk3 too.

[flatmax]

Yes, a large amount of the code works on gtk3. A few of the GUI components need updating.

…

On 11/5/20 8:11 am, HinTak wrote: Fedora has been gtk3 for quite a few years; Ubuntu is largely gtk3 for a couple of years now. You actually had one place in code , "include/Selection.H" where you check and error on gtk3. At least any file including that is meant to be gtk2 only. In the end I did the quick fix, which is changing "test/Makefile.am" around line 47, just after JackPortMonitorGuiTest/TimeTest to do GTK2 - which includes ScrollingTest - but maybe some of those work with gtk3 too. — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAFLUB7FE32DH6VTFKCM2ZDRQ4RATANCNFSM4M477SBQ>.