Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Scroll/zoom should stop animation #1767

Open
erikschul opened this issue Dec 10, 2023 · 3 comments · May be fixed by #1809
Open

[FEATURE] Scroll/zoom should stop animation #1767

erikschul opened this issue Dec 10, 2023 · 3 comments · May be fixed by #1809
Assignees
Labels
feature This issue requests a new feature P: 3 (low) (Default priority for feature requests) S: core Scoped to the core flutter_map functionality
Milestone

Comments

@erikschul
Copy link

What is the bug?

On web, when using mousedown-drag-mouseup to move the map, and then using mousewheel to zoom in/out, the movement continues and acts unexpectedly.

How can we reproduce it?

Do you have a potential solution?

See Google Maps, Bing Maps, or Apple Maps for industry standard implementation.

Platforms

web

Severity

Obtrusive: Prevents normal functioning but causes no errors in the console

@erikschul erikschul added bug This issue reports broken functionality or another error needs triage This new bug report needs reproducing and prioritizing labels Dec 10, 2023
@josxha
Copy link
Contributor

josxha commented Dec 10, 2023

What do you mean by "acts unexpectedly"? If I understand correctly you mean the fling gesture after you drag the map fast and suddenly stop. The current behaviour (at least on https://demo.fleaflet.dev ) is that if you scroll while the flint animation plays the fling animation continues but I see no weird behaviour at all.

Same as #1768, please provide more information about how your setup and how use FlutterMap.

@josxha josxha self-assigned this Dec 10, 2023
@JaffaKetchup JaffaKetchup added the S: core Scoped to the core flutter_map functionality label Dec 10, 2023
@erikschul
Copy link
Author

erikschul commented Dec 11, 2023

Thanks @josxha
I have added a video:
https://youtu.be/mrGEuOBrfsU

flutter_map: fling is jittery from combined effect of fling movement and zoom
google maps: mousewheel during fling causes movement to stop, such that only zoom is manipulated

My position is that it's easy to gain Flutter adoption if users are not surprised by the behavior of widgets. Users expect what they're used to, e.g. that of native Apple/Google Maps, so that is my reference for "expected behavior".

@josxha
Copy link
Contributor

josxha commented Dec 11, 2023

Thanks a lot for the additional information and video. I added it to #1733.

If you dont mind I'll ping you when the changes are implemented so that you can test it?

@josxha josxha added this to the v7.0 milestone Dec 11, 2023
@josxha josxha removed needs triage This new bug report needs reproducing and prioritizing waiting for user response labels Dec 11, 2023
@josxha josxha linked a pull request Dec 14, 2023 that will close this issue
38 tasks
@josxha josxha changed the title [BUG] Scroll/zoom should stop movement [BUG] Scroll/zoom should stop animation Dec 14, 2023
@JaffaKetchup JaffaKetchup added the P: 3 (low) (Default priority for feature requests) label Dec 15, 2023
@josxha josxha linked a pull request Jan 23, 2024 that will close this issue
@JaffaKetchup JaffaKetchup changed the title [BUG] Scroll/zoom should stop animation [FEATURE] Scroll/zoom should stop animation Aug 8, 2024
@JaffaKetchup JaffaKetchup added feature This issue requests a new feature and removed bug This issue reports broken functionality or another error labels Aug 8, 2024
@JaffaKetchup JaffaKetchup removed a link to a pull request Aug 8, 2024
38 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature This issue requests a new feature P: 3 (low) (Default priority for feature requests) S: core Scoped to the core flutter_map functionality
Projects
Status: In progress
Development

Successfully merging a pull request may close this issue.

3 participants