Approach for token uri method #22
-
@EmperorOrokuSaki @zoruka - this is regarding this comment: https://github.com/fleekxyz/contracts/blob/feat/fleek-erc721/contracts/FleekERC721.sol#L80. I proposed we do it like this so we can build dynamic URI based on sites db in contract. Otherwise we would have to keep an external JSON file on IPFS synced with this state. Maybe after POC we can benchmark that function and see if it's any performance hit and we can think about ways to improve it. It is a read function so it doesn't take gas but we can still take a closer look to see. What other pros are there about taking that approach? |
Beta Was this translation helpful? Give feedback.
Replies: 2 comments
-
We already solved this on POC so we can close this. |
Beta Was this translation helpful? Give feedback.
-
Update: I'm closing this discussion due to inactivity and the last comment that states this is solved. |
Beta Was this translation helpful? Give feedback.
We already solved this on POC so we can close this.