Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't generate endpointslice if there is no serviceexport bound with the service. #26

Open
lmxia opened this issue Mar 8, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@lmxia
Copy link
Contributor

lmxia commented Mar 8, 2024

We generate endpointslices for every Service in cluster, even they will never be exported across clusters.

We should only generate endpointslices for services which has ServiceExport.

@Airren Airren added the enhancement New feature or request label Mar 22, 2024
@oilbeater
Copy link

When investigating the code, I noticed that the endpoint and endpoints controller are watching all pods update, which may lead high cpu usage. Why not just watch the endpoint/endpoints updates, the pod updates should finally be reflected to endpoint/endpointslice.

@lmxia
Copy link
Contributor Author

lmxia commented Jun 20, 2024

When investigating the code, I noticed that the endpoint and endpoints controller are watching all pods update, which may lead high cpu usage. Why not just watch the endpoint/endpoints updates, the pod updates should finally be reflected to endpoint/endpointslice.

Nice point! @Airren please take a look at this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants