Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In the UI, it's unclear when pre-install condition isn't met #20782

Open
spokanemac opened this issue Jul 26, 2024 · 8 comments
Open

In the UI, it's unclear when pre-install condition isn't met #20782

spokanemac opened this issue Jul 26, 2024 · 8 comments
Labels
~dogfood Issue resulted from Fleet's product dogfooding.

Comments

@spokanemac
Copy link
Contributor

spokanemac commented Jul 26, 2024

Problem

Only in the install details in Fleet, can an admin see that this failed to install because it failed the pre-install condition.

20240725_134827_Dogfood Dashboard

There's no mention of "Pre-install condition"^

@spokanemac spokanemac added :product Product Design department (shows up on 🦢 Drafting board) ~feature fest Will be reviewed at next Feature Fest ~dogfood Issue resulted from Fleet's product dogfooding. labels Jul 26, 2024
@JoStableford
Copy link
Contributor

@noahtalerman
Copy link
Member

Hey @spokanemac thanks for tracking this!

pre-install condition was a platform check for Intel, and this is an Apple Silicon host.

I think for this specific use case, using labels (#19551) will be the best practice.

I think we'll want to use labels for all workflows in which we want restrict the scope within a team.

The pre-install condition will be used to check for requirements to install. For example, is the app closed? or is the configuration profile that delivered the system extension present?

Closing this issue. Please feel free to reopen if you disagree.

@fleet-release
Copy link
Contributor

Pre-qualified apps bloom,
In silicon's embrace found,
No vain retries loom.

@noahtalerman noahtalerman removed :product Product Design department (shows up on 🦢 Drafting board) ~feature fest Will be reviewed at next Feature Fest labels Jul 29, 2024
@spokanemac
Copy link
Contributor Author

@noahtalerman, Could we reframe this to give the user a clue into the error and why it's failing by sharing something like "Software failed to install because the pre-install condition failed"? I prefer a forward message on the self-service item instead of a tooltip, but enhancing the tooltip message would be a start.

@spokanemac spokanemac reopened this Jul 29, 2024
@noahtalerman noahtalerman changed the title Only offer self-service apps that pass the pre-install condition In the UI, it's unclear when pre-install condition isn't met Jul 29, 2024
@noahtalerman noahtalerman added the ~feature fest Will be reviewed at next Feature Fest label Jul 29, 2024
@noahtalerman
Copy link
Member

@spokanemac, I agree that the current copy, "Query didn't return a result or failed," is unclear.

I updated this issue to reflect that problem.

I also see a bug in the copy (no space before the timestamp in the parentheses)
Screenshot 2024-07-29 at 1 29 17 PM

I filed a bug for this here: #20810

@noahtalerman
Copy link
Member

@spokanemac is there any copy that says "if this keeps failing, reach out to your IT admin?"

JD: We could improve this to expose the pre-install query.

@noahtalerman
Copy link
Member

@spokanemac is there any copy that says "if this keeps failing, reach out to your IT admin?"

@spokanemac there is. See the screenshot here.

Could we reframe this to give the user a clue into the error and why it's failing by sharing something like "Software failed to install because the pre-install condition failed"?

Does the end user need to know this detail? Probably not because they can't do anything about it.

@spokanemac what do you think?

@spokanemac
Copy link
Contributor Author

Does the end user need to know this detail? Probably not because they can't do anything about it.

@spokanemac what do you think?

@noahtalerman IMNSHO, The worst messages are "This failed, please contact your IT admin."

Giving users a hint that they failed to meet a pre-condition (short of Fleet running the pre-condition well before we give users the option to self-service install the software) helps both know that it's not their fault the software install is failing, keeps the user from clicking install a second or third time, and they can contact the IT admin armed with more information as to why it's failing.

The real ask is that we run the pre-install query before ever offering the software in self-service. Adding a little information here is a middle-ground.

@noahtalerman noahtalerman removed the ~feature fest Will be reviewed at next Feature Fest label Aug 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
~dogfood Issue resulted from Fleet's product dogfooding.
Development

No branches or pull requests

4 participants