Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor UserInfo #7

Open
fletchowns opened this issue Nov 11, 2014 · 0 comments
Open

Refactor UserInfo #7

fletchowns opened this issue Nov 11, 2014 · 0 comments

Comments

@fletchowns
Copy link
Owner

From evol262:

AwfulClient.userinfo is a huge mess of shit that should be in UserInfo, which should inherit from AwfulClient and set all that in init. AwfulClient.userinfo can return UserInfo(userid) which sets it all

Everything you're doing with "contacts_elem.find('dt'..." could (and arguably should, so it's testable) be done from a private helper method that takes **kwargs if necessary to pass extra shit in. How many times is "elem.find(...).get_text()" in there?

Same for "[tag.extract() for tag in soup.findAll(...)]"

And in __process_paginators

@fletchowns fletchowns changed the title Refactor awfulclient Refactor UserInfo Nov 17, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant