Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CUDA testing support in proj #1537

Open
lockshaw opened this issue Nov 6, 2024 · 2 comments
Open

CUDA testing support in proj #1537

lockshaw opened this issue Nov 6, 2024 · 2 comments
Assignees

Comments

@lockshaw
Copy link
Collaborator

lockshaw commented Nov 6, 2024

No description provided.

@lockshaw lockshaw changed the title GPU testing support in proj CUDA testing support in proj Nov 6, 2024
@lockshaw
Copy link
Collaborator Author

From slack:

proj should be updated so that when someone runs proj test it checks for a GPU, and if a GPU is found it runs the GPU tests, and if the GPU is not found then it throws an error/prints an error message. An additional flag --skip-gpu-tests should be added to proj test that users without a GPU should run in order to not get that error

Also, while Dylan's command is correct, kernels currently does GPU tests in a somewhat outdated way. We're planning to move over to the model @reyna-abhyankar introduced in local-execution, where there are two doctest TEST_SUITEs, one for cuda tests and one for non-cuda tests

Eventually kernels should also be moved over to use this model

Example: https://github.com/reyna-abhyankar/FlexFlow/blob/79ef4c964fa4abebf9813166353ecce230b83c75/lib/local-execution/test/src/test_update_e2e.cc#L13

@chenzhuofu
Copy link
Collaborator

chenzhuofu commented Dec 19, 2024

Kernels tests was added to proj. You could check here. @lockshaw

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants