Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hash function doesn't hash #1556

Open
suranap opened this issue Dec 14, 2024 · 0 comments · May be fixed by #1557
Open

Hash function doesn't hash #1556

suranap opened this issue Dec 14, 2024 · 0 comments · May be fixed by #1557
Labels
bug Something isn't working

Comments

@suranap
Copy link
Collaborator

suranap commented Dec 14, 2024 •
edited
Loading

std::hash<int> doesn't hash, it just returns the int. So this code has a collision when dim[0] is 1 and 32.

https://github.com/flexflow/FlexFlow/blob/3a825ed6ae7425ea3578006e458cfcaf19e038a5/src/runtime/machine_view.cc#L49-L59

Solution is to use hash_combine in hash_utils.h.
@suranap suranap added the bug Something isn't working label Dec 14, 2024
@suranap suranap linked a pull request Dec 14, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change std::hash<int> to hash_combine suranap/flexflow-train
1 participant
@suranap