Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing functions in fq_default #2045

Open
GiacomoPope opened this issue Aug 7, 2024 · 1 comment
Open

Missing functions in fq_default #2045

GiacomoPope opened this issue Aug 7, 2024 · 1 comment

Comments

@GiacomoPope
Copy link
Contributor

The methods

  • fq_zech_is_primitive
  • fq_nmod_is_primitive
  • fq_is_primitive

and

  • fq_zech_multiplicative_order
  • fq_nmod_multiplicative_order
  • fq_multiplicative_order

suggest we could have

  • fq_default_is_primitive
  • fq_default_multiplicative_order

I've not contributed to FLINT before but this seems fairly easy. I'm happy to do it but wanted to check if they weren't included before for a particular reason

@GiacomoPope
Copy link
Contributor Author

I suppose the one catch here might be when the input has:

  • _FQ_DEFAULT_TYPE(ctx) == _FQ_DEFAULT_NMOD
  • _FQ_DEFAULT_TYPE(ctx) == _FQ_DEFAULT_FMPZ_MOD

as fmpz_mod and nmod dont seem to have these same functions. The "easy" thing to do in these two cases would be to take these values and construct fq and fq_nmod types from them, but it's not so elegant.

Maybe this is why these two special functions were not supported?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant