-
Notifications
You must be signed in to change notification settings - Fork 244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Autotools build works only in the source directory #2077
Comments
Out of tree builds has been an issue for over 10 years (see #30).
These rules exists to update files like
There should be no need to have Autotools if you aim to just install FLINT. Any release available here on Github should not require it. |
If out of tree builds is an issue for someone, let us know. I thought of fixing it this spring at the FLINT workshop, but no one at the time would really benefit from it, so I didn't fix it. |
https://github.com/flintlib/flint/releases/download/v3.1.3/flint-3.1.3.tar.xz and Autoconf was truly required to obtain an internally consistent build.
Yes, there are automated pipelines at CRAN that routinely build external libraries from sources out of tree (see, e.g., https://github.com/r-macos/recipes). Since Autotools was designed in the first place to handle out of tree builds, it has not been an issue before. |
Agreed! Thanks for bringing this up, will fix this.
Alright. I believe I will fix this for FLINT v3.2.0 (I would guess it will be released after the next workshop in December or January, but we haven't really talked about the next release). |
That issue has been fixed in our release script. |
Closing this as #30 was solved. Please reopen if something was not settled. |
Thanks. Is there any hope of creating a minimal diff against the latest release, supporting an out of tree build? That would allow me to move forward with getting FLINT installed on CRAN's machines. If there's been huge divergence, then I'll understand if I'm just out of luck here ... |
It shouldn't be too hard to do, but I get conflicts in |
Under macOS,
|
make
fails immediately ifconfigure
was not run in the source directory.The cause seems to be kludge in
Makefile.in
:Why are there rules for making
x
fromx.in
, when that is already done byconfigure
beforemake
is ever run? From an outsider perspective, the build system is nonconforming, if not broken.For context, I am writing an R package that provides an R interface to FLINT. Due to the above issue and due to the implicit dependency on users or administrators having Autotools installed (in order to update configuration files themselves, when that is typically done by maintainers before tarballs are built), it is unlikely that CRAN will maintain installations of FLINT on its check platforms. That is a huge barrier to developers submitting to CRAN R packages that link FLINT, because it means that packages must bundle the FLINT sources.
The text was updated successfully, but these errors were encountered: