From 09bdc42804e6afd2d470e883b38a66a67dcc09f0 Mon Sep 17 00:00:00 2001 From: Mark Phelps <209477+markphelps@users.noreply.github.com> Date: Fri, 6 Oct 2023 07:42:27 -0400 Subject: [PATCH] chore: fix remaining screenshots script issues (#2204) --- ui/screenshot/concepts/distributions.js | 3 ++- ui/screenshot/concepts/rules.js | 3 ++- ui/screenshot/getting_started/create-rule.js | 2 +- 3 files changed, 5 insertions(+), 3 deletions(-) diff --git a/ui/screenshot/concepts/distributions.js b/ui/screenshot/concepts/distributions.js index 2861ed91f2..95e1cd439a 100644 --- a/ui/screenshot/concepts/distributions.js +++ b/ui/screenshot/concepts/distributions.js @@ -1,8 +1,9 @@ -const { capture } = require('../../screenshot.js'); +const { capture, scrollToBottom } = require('../../screenshot.js'); (async () => { await capture('concepts', 'distributions', async (page) => { await page.getByRole('link', { name: 'colorscheme' }).click(); await page.getByRole('link', { name: 'Rules' }).click(); + await scrollToBottom(page); }); })(); diff --git a/ui/screenshot/concepts/rules.js b/ui/screenshot/concepts/rules.js index 9582a9b5d3..c1e2a6bb58 100644 --- a/ui/screenshot/concepts/rules.js +++ b/ui/screenshot/concepts/rules.js @@ -1,8 +1,9 @@ -const { capture } = require('../../screenshot.js'); +const { capture, scrollToBottom } = require('../../screenshot.js'); (async () => { await capture('concepts', 'rules', async (page) => { await page.getByRole('link', { name: 'colorscheme' }).click(); await page.getByRole('link', { name: 'Rules' }).click(); + await scrollToBottom(page); }); })(); diff --git a/ui/screenshot/getting_started/create-rule.js b/ui/screenshot/getting_started/create-rule.js index d4943456a4..4777602523 100644 --- a/ui/screenshot/getting_started/create-rule.js +++ b/ui/screenshot/getting_started/create-rule.js @@ -5,7 +5,7 @@ const { capture } = require('../../screenshot.js'); await page.getByRole('link', { name: 'new-login' }).click(); await page.getByRole('link', { name: 'Rules' }).click(); await page.getByRole('button', { name: 'New Rule' }).click(); - await page.locator('#segmentKey-select-button').click(); + await page.locator('#segmentKey-0-select-button').click(); await page.getByText('all-users').click(); await page.getByLabel('Multi-Variate').check(); });