Skip to content
This repository has been archived by the owner on Aug 2, 2020. It is now read-only.

Tracking issue for existing changes to incorporate #2

Open
clarfonthey opened this issue Feb 9, 2019 · 4 comments
Open

Tracking issue for existing changes to incorporate #2

clarfonthey opened this issue Feb 9, 2019 · 4 comments
Labels
E-small (A) Small (effort) to implement P-substantial (A) Substantial (impact) of change S-existing-changes (Source) is from changes people have already made
Milestone
v2.x.1.0 (Breakin...

Comments

@clarfonthey
Copy link
Member

clarfonthey commented Feb 9, 2019 •
edited
Loading

Tracking issues:

Links:

General notes:

  • CSS underlines hack
  • Keeping CW box open

Any others?
@clarfonthey clarfonthey added this to the 1.x.x milestone Feb 9, 2019
@clarfonthey clarfonthey pinned this issue Feb 9, 2019
@clarfonthey clarfonthey added the S-existing-changes (Source) is from changes people have already made label Feb 9, 2019
@clarfonthey clarfonthey modified the milestones: 1.x.x, 2.0.0 Feb 9, 2019
@clarfonthey clarfonthey changed the title Master list of forks to incorporate Master list of existing changes to incorporate Feb 9, 2019
@ghost
Copy link

ghost commented Feb 10, 2019

Keeping the CW box open is an option in glitchsoc's compose box UI settings, so it should be covered by #3 with "app settings modal." ^w^

Additionally, we can toss our custom CSS for underlined links, but the changes to the high contrast theme in default mastodon may cover it better, and perhaps it's worth considering making the most accessible theme the default? That might be worth creating a separate issue for actually discussing.

@clarfonthey
Copy link
Member Author

I also definitely need to add Switter and sleeping.town to this list.

@falkreon
Copy link

We also get a bunch of accessibility issues that are really mainline issues, so it might be worth peeking at sleeping's Issue tracker too - https://github.com/unascribed/sleeping.town/issues
I'm looking forward to seeing florence take shape, thanks for all the work you're doing :)

@clarfonthey clarfonthey modified the milestones: v1.2, v2 May 25, 2019
@clarfonthey clarfonthey changed the title Master list of existing changes to incorporate Tracking issue of existing changes to incorporate Jun 7, 2019
@clarfonthey clarfonthey changed the title Tracking issue of existing changes to incorporate Tracking issue for existing changes to incorporate Jun 7, 2019
@clarfonthey clarfonthey added E-small (A) Small (effort) to implement P-substantial (A) Substantial (impact) of change labels Jun 7, 2019
@mal0ki
Copy link
Member

mal0ki commented Jun 16, 2019

Should we add check-boxes to the Tracking list, and then check them as we incorporate them for easier overview? I can edit your post for you if you like @clarfon

agateblue pushed a commit to agateblue/mastodon-fork that referenced this issue Feb 28, 2020
@ntl-purism @Gargron
LDAP & PAM added to OAuth password grant strategy (#7999) (#12390)
f3a9398 
When authenticating via OAuth, the resource owner password grant
strategy is allowed by Mastodon, but (without this PR), it does not
attempt to authenticate against LDAP or PAM. As a result, LDAP or PAM
authenticated users cannot sign in to Mastodon with their
email/password credentials via OAuth (for instance, for native/mobile
app users).

This PR fleshes out the authentication strategy supplied to doorkeeper
in its initializer by looking up the user with LDAP and/or PAM when
devise is configured to use LDAP/PAM backends. It attempts to follow the
same logic as the Auth::SessionsController for handling email/password
credentials.

Note florence-social#1: Since this pull request affects an initializer, it's unclear
how to add test automation.

Note florence-social#2: The PAM authentication path has not been manually tested. It
was added for completeness sake, and it is hoped that it can be manually
tested before merging.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
E-small (A) Small (effort) to implement P-substantial (A) Substantial (impact) of change S-existing-changes (Source) is from changes people have already made
Milestone
v2.x.1.0 (Breaking-Release 1.0)
Development

No branches or pull requests
3 participants
@falkreon @clarfonthey @mal0ki