Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bring psidR back to CRAN? #61

Open
zeileis opened this issue Sep 23, 2024 · 5 comments
Open

Bring psidR back to CRAN? #61

zeileis opened this issue Sep 23, 2024 · 5 comments

Comments

@zeileis
Copy link

zeileis commented Sep 23, 2024

Florian @floswald, as co-maintainer of the Econometrics CRAN task view I noticed that psidR was recently archived on CRAN for internet access policy violations. Do you plan on updating the package and bringing it back to CRAN? Can I help with anything?

Thanks in advance for your work on the package & best wishes, Achim

@floswald
Copy link
Owner

hey @zeileis
whoops yes indeed, I completely forgot about that. I do plan to bring it back. do I need to do anything else apart from re-submitting it? thanks

@zeileis
Copy link
Author

zeileis commented Sep 24, 2024

Usually, the crucial point with internet access from the CRAN Policy is:

Packages which use Internet resources should fail gracefully with an informative message if the resource is not available or has changed (and not give a check warning nor error).

I guess (haven't looked at the details) that when you open URLs via openxlsx::read.xlsx(), then it might lead to an error if download.file() does not work. This again will probably lead to an error in R CMD check.

So before resubmitting you should make sure that the checks work successfully also if you are offline.

@floswald
Copy link
Owner

yes indeed - it did not help that my package tests were running on Uwe Ligge's server on the day that the internet stopped working (crowdstrike incident). I have turned off that particular test now, not related to package functionality anyway. So, I just resubmit as new version, that's it?

@zeileis
Copy link
Author

zeileis commented Sep 24, 2024

Great, thank you! And, yes, just re-submit and briefly explain in the comment field what lead to the archival and that you have addressed that issue now.

@zeileis
Copy link
Author

zeileis commented Oct 26, 2024

Florian, just wanted to check whether you have had the chance to look at this (prompted by cran-task-views/Econometrics#28). Let me know if I can help with anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants