Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix leaking goroutines when using Google KMS keys #167

Open
nanuuki opened this issue Aug 31, 2021 · 1 comment
Open

Fix leaking goroutines when using Google KMS keys #167

nanuuki opened this issue Aug 31, 2021 · 1 comment
Assignees
@nanuuki
Labels
bug Something isn't working

Comments

@nanuuki
Copy link
Contributor

nanuuki commented Aug 31, 2021

The KeyManagementClients needs to be closed to avoid leaking goroutines;

  • in keys/google/google.go; Generate and Signer functions

Currently tests fail when using Google KMS keys (FLOW_WALLET_DEFAULT_KEY_TYPE=google_kms)
@nanuuki nanuuki added the bug Something isn't working label Aug 31, 2021
@nanuuki nanuuki mentioned this issue Aug 31, 2021
Merged
@nanuuki nanuuki self-assigned this Dec 8, 2021
@nanuuki
Copy link
Contributor Author

nanuuki commented Dec 9, 2021

This would allow closing the client manually; onflow/flow-go-sdk#204

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nanuuki nanuuki

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@nanuuki