Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schema files are out of date #7

Closed
jonnor opened this issue Jan 6, 2016 · 12 comments
Closed

Schema files are out of date #7

jonnor opened this issue Jan 6, 2016 · 12 comments
Labels

Comments

@jonnor
Copy link
Contributor

jonnor commented Jan 6, 2016

To get out of this, we should make the schemas the canonical single-source-of-truth for all protocol description. Currently this information is in https://github.com/noflo/noflo.github.io/blob/master/documentation/_posts/2013-07-09-protocol.md
The human-readable documentation page should be generated from the JSON schemas

@jonnor jonnor added the bug label Jan 6, 2016
@jonnor
Copy link
Contributor Author

jonnor commented Jan 6, 2016

Needed for flowbased/flowtrace#16

@jonnor
Copy link
Contributor Author

jonnor commented May 18, 2016

Now we the prose in this project at https://github.com/flowbased/fbp-protocol/blob/master/spec/protocol.md and we generate docs from and autodeploy to: http://flowbased.github.io/fbp-protocol
So next step would be to migrate payload descriptions into the schemas, and generate the Markdown/HTML from that

@chadrik
Copy link
Contributor

chadrik commented May 18, 2016

@jonnor, @ifitzpatrick and I can write a python script for this. I'm considering using jinja so that we can make a template .md file that loops over data pulled from the schema files. That will give us easy control over how the final doc is built.

@jonnor
Copy link
Contributor Author

jonnor commented May 18, 2016

Cool. Yep, generating an .md for the things coming from schema (or a set of
.md files) will be easy to integrate with other doc-building tools.

On 18 May 2016 at 22:55, Chad Dombrova [email protected] wrote:

@jonnor https://github.com/jonnor, @ifitzpatrick
https://github.com/ifitzpatrick and I can write a python script for
this. I'm considering using jinja http://jinja.pocoo.org/ so that we
can make a template .md file that loops over data pulled from the schema
files. That will give us easy control over how the final doc is built.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#7 (comment)

Jon Nordby - www.jonnor.com

@jonnor
Copy link
Contributor Author

jonnor commented Jun 9, 2016

Related to #17

@chadrik
Copy link
Contributor

chadrik commented Jun 10, 2016

@jonnor #17 is pretty much ready to go. I think it just needs the flowtrace additions. Should we merge it in and then have you or @bergie update it with the flowtrace stuff?

@jonnor
Copy link
Contributor Author

jonnor commented Jun 11, 2016

@chadrik reviewed and found some problems with #17, see latest comments there. I think we can do the tracing subprotocol after we merge that, though can't really close this issue until it is all in.

@chadrik
Copy link
Contributor

chadrik commented Jun 11, 2016

Yep. Saw it and thanks for reviewing. Should be taken care of early next week.

@chadrik
Copy link
Contributor

chadrik commented Jun 21, 2016

To close this ticket I think we just need the flowtrace stuff. @jonnor is that feature targeted for version 0.6 of the protocol?

@jonnor
Copy link
Contributor Author

jonnor commented Jun 22, 2016

I think we should keep version bumps (like going to 0.6) to incompatible changes only.
The flowtrace stuff is only additions, and part of a new 'capability', and thus should not break any existing clients/runtimes. But I will move it into schemas so we can complete this.

@chadrik
Copy link
Contributor

chadrik commented Jun 22, 2016

Sure, makes sense.

@jonnor
Copy link
Contributor Author

jonnor commented Jun 22, 2016

@jonnor jonnor closed this as completed Jun 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants