Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove CONFIG_DEFINITION initializations #64

Open
jesseylin opened this issue Aug 28, 2023 · 0 comments
Open

remove CONFIG_DEFINITION initializations #64

jesseylin opened this issue Aug 28, 2023 · 0 comments

Comments

@jesseylin
Copy link
Contributor

there is a test case in test_expose_config.py that documents this. basically exposing configs does not work well with inheritance. A fix
would be to remove the CONFIG_DEFINITION={} initializations (which are mutable) from Leaf, which everything inherits, but this
will break legacy compatibility.

Suggest biting the bullet and making a breaking change and changing the legacy code.
jesseylin added a commit that referenced this issue Sep 19, 2023
@jesseylin
test: add some tests for issue #64
91e2c1c
jesseylin added a commit that referenced this issue Feb 29, 2024
@jesseylin
test: add some tests for issue #64
fbb7618
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jesseylin