Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

option to not save images that turn out larger. #50

Open
Kochega opened this issue Mar 6, 2024 · 1 comment
Open

option to not save images that turn out larger. #50

Kochega opened this issue Mar 6, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@Kochega
Copy link

Kochega commented Mar 6, 2024

Give us an option under settings so that images that turn out larger then the original is not saved to the PC.

@Kochega Kochega added the enhancement New feature or request label Mar 6, 2024
@flozz
Copy link
Owner

flozz commented Mar 6, 2024

Hello,

This option will not be implemented (but for good reason):

  • When converting an image from a format to another one, YOGA is allowed to output an image larger than the input one.
  • When transforming an image (resize, color quantization), YOGA is allowed to output larger file (but in practice it is rarely the case)
  • When the output format is the same as the input one, YOGA should not generate a larger output → This is considered as a bug.

I know this is not yet the case for this latest point:

  • PNG: it should be working currently ✅️
  • JPEG: it is not the case, I have to fix it (it is in my todo list along to the fast and lossless jpeg optim) ❌️
  • WebP: I also have to work on it, but it will be a lot simpler. ❌️

I hope I will have time to fix this behavior until the end of the year :)

@flozz flozz added bug Something isn't working and removed enhancement New feature or request labels Mar 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants