Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parallel processing: are slices copied across threads correctly? #138

Open
elgiano opened this issue Aug 17, 2022 · 1 comment
Open

Parallel processing: are slices copied across threads correctly? #138

elgiano opened this issue Aug 17, 2022 · 1 comment

Comments

@elgiano
Copy link
Contributor

elgiano commented Aug 17, 2022

From the Oslo workshop some months ago, I remember that buffer slices were not copied correctly across threads: instead of copying only the portion from startSample to startSample + numSamples, the whole buffer would be copied.
Is this still the case?

Thanks!

@weefuzzy
Copy link
Member

It's not so much an issue of correctness – as far as I know the parallel process will still honour the selected range (if it doesn't, then obviously there's a bug) – but of redundant copying that is especially problematic when doing lots of small analyses on a single large buffer.

Anyway, no, I haven't fixed this yet. But I will, honest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants