Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #862 #1077

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix #862 #1077

wants to merge 1 commit into from

Conversation

umens
Copy link

@umens umens commented Oct 29, 2020

Fix the following Webpack Warning:
WARNING in ./node_modules/fluent-ffmpeg/lib/options/misc.js 27:21-40
Critical dependency: the request of a dependency is an expression

@umens
fix fluent-ffmpeg#862
5debbe2 
Fix the following Webpack Error:
WARNING in ./node_modules/fluent-ffmpeg/lib/options/misc.js 27:21-40
Critical dependency: the request of a dependency is an expression
@umens umens mentioned this pull request Oct 29, 2020
Open
2 tasks
@moshfeu
Copy link

moshfeu commented Oct 29, 2020

Nice.
If it's working, that embarrassing ;)

@shlajin
Copy link

shlajin commented Feb 19, 2021

I can confirm that it works

trongnhan136 pushed a commit to trongnhan136/node-fluent-ffmpeg that referenced this pull request Jul 29, 2021
fix fluent-ffmpeg#862 fluent-ffmpeg#1077
5e6cc4d
@valoricDe
Copy link

Is there something blocking to merge this?

@dohsimpson
Copy link

+1

@mfucci
Copy link

mfucci commented Nov 3, 2024 •
edited
Loading

+1

For others - current workaround that works, add this in your webpack config to ignore this error (as seen on medium.com):

plugins: [
    new ContextReplacementPlugin(
      /\/fluent-ffmpeg\//,
      (data: any) => {
        delete data.dependencies[0].critical;
        return data;
      },
    ),
]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@umens @moshfeu @shlajin @valoricDe @dohsimpson @mfucci