New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Migrate testing to Go's testing package #106

Open

fujimotos opened this issue Nov 7, 2021 · 1 comment

Member

fujimotos commented Nov 7, 2021

While writing a unit test for #105, I noticed that https://github.com/bmizerany/assert
has been abandoned (circa 2016).

The current preferred way to implement testing seems to be Go's testing package.
Let's migrate fluent-logger-golang's testing to use it.

The text was updated successfully, but these errors were encountered:

wasim-nihal added a commit to wasim-nihal/fluent-logger-golang that referenced this issue


          Migration to go testing framework. Fixes issue 106

Migrating from "github.com/bmizerany/assert" (which is not maintained now) to "github.com/stretchr/testify/assert"

Fix for fluent#106

wasim-nihal mentioned this issue

Migration to go's test assertion framework. Fixes issue #106 #121

Open

wasim-nihal commented Jul 31, 2023

Hi, I would like to contribute here. Please find the PR for this change #121 and let me know if any changes are required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment