Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Licensing builtin with reuse #1099

Open
dsalaza4 opened this issue May 31, 2023 · 2 comments · Fixed by #1107
Open

Licensing builtin with reuse #1099

dsalaza4 opened this issue May 31, 2023 · 2 comments · Fixed by #1107

Comments

@dsalaza4
Copy link
Contributor

Let's create a testLicense builtin with reuse.

We already have a custom job for it: https://github.com/fluidattacks/makes/tree/main/makes/license
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jun 11, 2023
@rohaquinlop
feat(build) fluidattacks#1099 licensing builtin with reuse
699ebd7 
- Create `testLicense` builtin with reuse.
- Add job to dev pipeline

Signed-off-by: Robin Hafid Quintero Lopez <[email protected]>
@rohaquinlop rohaquinlop mentioned this issue Jun 11, 2023
Merged
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jun 12, 2023
@rohaquinlop
feat(build) fluidattacks#1099 licensing builtin with reuse
465466f 
- Create `testLicense` builtin with reuse.
- Add job to dev pipeline

Signed-off-by: Robin Hafid Quintero Lopez <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jun 12, 2023
@rohaquinlop
feat(build) fluidattacks#1099 licensing builtin with reuse
835af65 
- Create `testLicense` builtin with reuse.
- Add job to dev pipeline

Signed-off-by: Robin Hafid Quintero Lopez <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jun 12, 2023
@rohaquinlop
feat(build): fluidattacks#1099 licensing builtin with reuse
d1f39a8 
- Create `testLicense` builtin with reuse.
- Add job to dev pipeline

Signed-off-by: Robin Hafid Quintero Lopez <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jun 13, 2023
@rohaquinlop
feat(build): fluidattacks#1099 licensing builtin with reuse
fc63c50 
- Create `testLicense` builtin with reuse.
- Add job to dev pipeline

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jun 13, 2023
@rohaquinlop
feat(build): fluidattacks#1099 licensing builtin with reuse
c788ac1 
- Create `testLicense` builtin with reuse.
- Add job to dev pipeline

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jun 13, 2023
@rohaquinlop
feat(build): fluidattacks#1099 licensing builtin with reuse
6ff95ba 
- Create `testLicense` builtin with reuse.
- Add job to dev pipeline

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jun 13, 2023
@rohaquinlop
feat(build): fluidattacks#1099 licensing builtin with reuse
64d4aca 
- Create `testLicense` builtin with reuse.
- Add job to dev pipeline

Signed-off-by: Robin Quintero <[email protected]>
dsalaza4 pushed a commit to dsalaza4/makes that referenced this issue Jun 13, 2023
@rohaquinlop @dsalaza4
feat(build): fluidattacks#1099 licensing builtin with reuse
cb3971e 
- Create `testLicense` builtin with reuse.
- Add job to dev pipeline

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jun 13, 2023
@rohaquinlop
feat(build): fluidattacks#1099 licensing builtin with reuse
e599f19 
- Create `testLicense` builtin with reuse.
- Add job to dev pipeline

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jun 13, 2023
@rohaquinlop
feat(build): fluidattacks#1099 licensing builtin with reuse
6e761e8 
- Create `testLicense` builtin with reuse.
- Add job to dev pipeline

Signed-off-by: Robin Quintero <[email protected]>
rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jun 13, 2023
@rohaquinlop
feat(build): fluidattacks#1099 licensing builtin with reuse
de36dbf 
- Create `testLicense` builtin with reuse.
- Add job to dev pipeline

Signed-off-by: Robin Quintero <[email protected]>
dsalaza4 added a commit that referenced this issue Jun 13, 2023
@dsalaza4
Merge pull request #1107 from rohaquinlop/testLicense
97ccd84 
feat(build): #1099 licensing builtin with reuse
@dsalaza4 dsalaza4 reopened this Jul 1, 2023
@dsalaza4
Copy link
Contributor Author

dsalaza4 commented Jul 1, 2023

@rohaquinlop,

I am reopening this issue as I just discovered a bug:

  1. Remove all testLicense references within the repository.
  2. Run m .
  3. You will still see a /testlicense job.

This should not be the case, as outputs should only be created when a testLicense is declare within the makes.nix file

@rohaquinlop
Copy link
Collaborator

Got it! @dsalaza4

rohaquinlop added a commit to rohaquinlop/makes that referenced this issue Jul 3, 2023
@rohaquinlop
feat(build): fluidattacks#1099 fix testlicense bug
4f33658 
- fix `testlicense` still appears when there is no references.

Signed-off-by: Robin Quintero <[email protected]>
dsalaza4 added a commit that referenced this issue Jul 4, 2023
@dsalaza4
Merge pull request #1117 from rohaquinlop/fix-bug-testLicense
91ee9fe 
feat(build): #1099 fix testlicense bug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(build): fluidattacks#1099 licensing builtin with reuse rohaquinlop/makes
2 participants
@dsalaza4 @rohaquinlop