New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate signals to subprocess #1154

Open

dacevedo12 opened this issue Sep 7, 2023 · 0 comments

Collaborator

dacevedo12 commented Sep 7, 2023

In non-interactive environments, signals are sent to the container's main process under certain circumstances.

I.e, kubernetes sends a SIGTERM which can be handled to gracefully shutdown applications before the pod gets stopped

Given that makes is the main process, it should propagate those signals to the underlying application being executed

https://github.com/fluidattacks/makes/blob/main/src/cli/main/cli.py#L477

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment