Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hashing scheme for txs is buggy #226

Open
noel2004 opened this issue Nov 9, 2021 · 0 comments
Open

Hashing scheme for txs is buggy #226

noel2004 opened this issue Nov 9, 2021 · 0 comments

Comments

@noel2004
Copy link
Member

noel2004 commented Nov 9, 2021

Currently the hashing scheme for txs, which is used as witness and signed by user's L2 key, still seems to be buggy. Like:

  • In transfer and redraw tx, the hashed amount is divided by 1,000,000 (a hard coded magic number)
  • Nonce is not really being hashed in redraw tx
  • Old balance is planned to be involved in redraw tx, but I consider this is not a good idea because deposit and spotTrade both can change the current balance at any time and make the signed redraw tx invalided
  • Witness of order input lack of any fields for prohibiting aggregator replaying them (like put one order to multiple open slots)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant