From 9d6ba59225b116be8bb41bbd0676fe9ade568a4e Mon Sep 17 00:00:00 2001 From: Chun-Heng Tai Date: Fri, 1 Sep 2023 15:47:27 -0700 Subject: [PATCH] review comments --- packages/devtools_shared/CHANGELOG.md | 7 ++++--- .../devtools_shared/lib/src/deeplink/deeplink_manager.dart | 1 - packages/devtools_shared/lib/src/server/server_api.dart | 5 +++-- 3 files changed, 7 insertions(+), 6 deletions(-) diff --git a/packages/devtools_shared/CHANGELOG.md b/packages/devtools_shared/CHANGELOG.md index fdef61c36f3..65690907631 100644 --- a/packages/devtools_shared/CHANGELOG.md +++ b/packages/devtools_shared/CHANGELOG.md @@ -1,10 +1,11 @@ # 4.0.0 - Bump `package:extension_discovery` version to ^2.0.0 -- Adds a `DeeplinkApi.androidBuildVariants` endpoint to ServerAPi. +- Adds a `DeeplinkApi.androidBuildVariants` endpoint to ServerApi. - **BREAKING CHANGE**: - - ServerApi.handle extensionsManager, api parameter are converted to named parameters - - Adds a new required name parameter deeplinkManager to `ServerApi.handle`. + - `ServerApi.handle` parameters `extensionsManager` and `api` were converted to named + parameters + - Adds a new required named parameter `deeplinkManager` to `ServerApi.handle`. # 3.0.1 diff --git a/packages/devtools_shared/lib/src/deeplink/deeplink_manager.dart b/packages/devtools_shared/lib/src/deeplink/deeplink_manager.dart index 08c2f0b846d..54276e93b28 100644 --- a/packages/devtools_shared/lib/src/deeplink/deeplink_manager.dart +++ b/packages/devtools_shared/lib/src/deeplink/deeplink_manager.dart @@ -51,7 +51,6 @@ class DeeplinkManager { }; } return { - kErrorField: null, kOutputJsonField: outputJson, }; } diff --git a/packages/devtools_shared/lib/src/server/server_api.dart b/packages/devtools_shared/lib/src/server/server_api.dart index e6db6327aeb..acb7df96aa3 100644 --- a/packages/devtools_shared/lib/src/server/server_api.dart +++ b/packages/devtools_shared/lib/src/server/server_api.dart @@ -396,7 +396,8 @@ abstract class _DeeplinkApiHandler { if (error != null) { api.serverError(error); } - return api - .getCompleted(result[DeeplinkManager.kOutputJsonField]! as String); + return api.getCompleted( + result[DeeplinkManager.kOutputJsonField]! as String, + ); } }