Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record the set of widgets that contributed to each layer in the Raster stats tool #5851

Closed
kenzieschmoll opened this issue May 26, 2023 · 2 comments
Labels
P2 important to work on, but not at the top of the work list. screen: performance Issues with the Performance screen
Milestone

Comments

@kenzieschmoll
Copy link
Member

Right now, we only have an image of the layer to guide users to the code in their app that may have contributed to it. Instead, we should provide them with the set of widgets that contributed to each layer.

@iskakaushik was working on this at one point, and another option we discussed was providing the set of render objects, or in the future, providing a set of draw commands that we could replay in DevTools to show their cost.

@jacob314 jacob314 added this to the On Deck milestone May 30, 2023
@polina-c polina-c added the P4 label May 31, 2023
@kenzieschmoll kenzieschmoll added P2 important to work on, but not at the top of the work list. and removed P4 labels Jul 5, 2023
@kenzieschmoll
Copy link
Member Author

From an offline discussion with @jacob314. Posting here to track.

There is a fine mapping from render objects to widgets although you might have to add a flag to enable it in profile mode, etc. There should be ways to do all or almost all of it in the framework side. Basically just flow back unique ids for the layers from the engine, and then do the rest of the logic in the framework. For example here is where each widget tracks its layer

and here is all it takes given a renderObject to get the Element (if you are in debug)

@kenzieschmoll
Copy link
Member Author

This feature has been removed from DevTools, so closing this as obsolete.

@kenzieschmoll kenzieschmoll closed this as not planned Won't fix, can't repro, duplicate, stale Jul 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P2 important to work on, but not at the top of the work list. screen: performance Issues with the Performance screen
Projects
None yet
Development

No branches or pull requests

3 participants