Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue while inspecting App bar and floating action button #5985

Closed
CoderDake opened this issue Jul 4, 2023 · 2 comments
Closed

Issue while inspecting App bar and floating action button #5985

CoderDake opened this issue Jul 4, 2023 · 2 comments
Assignees

Comments

@CoderDake
Copy link
Contributor

While testing multi view i have noticed that trying to inspect the app bar or the floating action button results in a stack overflow error.
Screenshot 2023-07-04 at 2 17 56 PM

{"exception":"Stack Overflow","stack":"#0      _AssertionError._evaluateAssertion (dart:core-patch/errors_patch.dart:56:3)\n#1      _LinkedHashMapMixin._insert (dart:collection-patch/compact_hash.dart)\n#2      _LinkedHashMapMixin._set (dart:collection-patch/compact_hash.dart:519:7)\n#3      _LinkedHashMapMixin._insert (dart:collection-patch/compact_hash.dart:465:7)\n#4      _LinkedHashMapMixin._set (dart:collection-patch/compact_hash.dart:519:7)\n#5      DiagnosticsNode.toJsonMap.<anonymous closure> (package:flutter/src/foundation/diagnostics.dart:1611:22)\n#6      DiagnosticsNode.toJsonMap (package:flutter/src/foundation/diagnostics.dart:1650:6)\n#7      DiagnosticsProperty.toJsonMap (package:flutter/src/foundation/diagnostics.dart:2618:45)\n#8      FlagProperty.toJsonMap (package:flutter/src/foundation/diagnostics.dart:2120:45)\n#9      DiagnosticsNode.toJsonList.<anonymous closure> (package:flutter/src/foundation/diagnostics.dart:1675:19)\n#10     new _GrowableList._ofEfficientLengthIterable (dart:core-patch/growable_array.dart:189:27)\n#11     new _GrowableList.of (dart:core-patch/growable_array.dart:150:28)\n#12     DiagnosticsNode.toJsonList (package:flutter/src/foundation/diagnostics.dart:1676:8)\n#13     DiagnosticsNode.toJsonMap.<anonymous closure> (package:flutter/src/foundation/diagnostics.dart:1637:25)\n#14     DiagnosticsNode.toJsonMap (package:flutter/src/foundation/diagnostics.dart:1650:6)\n#15     WidgetInspectorService._getLayoutExplorerNode.<anonymous closure> (package:flutter/src/widgets/widget_inspector.dart:2057:62)\n#16     InspectorSerializationDelegate.additionalNodeProperties (package:flutter/src/widgets/widget_inspector.dart:3627:53)\n#17     DiagnosticsNode.toJsonMap.<anonymous closure> (package:flutter/src/foundation/diagnostics.dart:1635:21)\n#18     DiagnosticsNode.toJsonMap (package:flutter/src/foundation/diagnostics.dart:1650:6)\n#19     _ElementDiagnosticableTreeNode.toJsonMap (package:flutter/src/widgets/framework.dart:5076:45)\n#20     WidgetInspectorService._getLayoutExplorerNode.<anonymous closure> (package:flutter/src/widgets/widget_inspector.dart:2065:61)\n#21     InspectorSerializationDelegate.additionalNodeProperties (package:flutter/src/widgets/widget_inspector.dart:3627:53)\n#22     DiagnosticsNode.toJsonMap.<anonymous closure> (package:flutter/src/foundation/diagnostics.dart:1635:21)\n#23     DiagnosticsNode.toJsonMap (package:flutter/src/foundation/diagnostics.dart:1650:6)\n#24     _ElementDiagnosticableTreeNode.toJsonMap (package:flutter/src/widgets/framework.dart:5076:45)\n#25     WidgetInspectorService._getLayoutExplorerNode.<anonymous closure> (package:flutter/src/widgets/widget_inspector.dart:2065:61)\n#26     InspectorSerializationDelegate.additionalNodeProperties (package:flutter/src/widgets/widget_inspector.dart:3627:53)\n#27     DiagnosticsNode.toJsonMap.<anonymous closure> (package:flutter/src/foundation/diagnostics.dart:1635:21)\n#28     DiagnosticsNode.toJsonMap (package:flutter/src/foundation/diagnostics.dart:1650:6)\n#29     _ElementDiagnosticableTreeNode.toJsonMap (package:flutter/src/widgets/framework.dart:5076:45)\n#30     WidgetInspectorService._getLayoutExplorerNode.<anonymous closure> (package:flutter/src/widgets/widget_inspector.dart:2065:61)\n#31     InspectorSerializationDelegate.additionalNodeProperties (package:flutter/src/widgets/widget_inspector.dart:3627:53)\n#32     DiagnosticsNode.toJsonMap.<anonymous closure> (package:flutter/src/foundation/diagnostics.dart:1635:21)\n#33     DiagnosticsNode.toJsonMap (package:flutter/src/foundation/diagnostics.dart:1650:6)\n#34     _ElementDiagnosticableTreeNode.toJsonMap (package:flutter/src/widgets/framework.dart:5076:45)\n#35     WidgetInspectorService._getLayoutExplorerNode.<anonymous closure> (package:flutter/src/widgets/widget_inspector.dart:2065:61)\n#36     InspectorSerializationDelegate.additionalNodeProperties (package:flutter/src/widgets/widget_inspector.dart:3627:53)\n#37     DiagnosticsNode.toJsonMap.<anonymous closure> (package:flutter/src/foundation/diagnostics.dart:1635:21)\n#38     DiagnosticsNode.toJsonMap (package:flutter/src/foundation/diagnostics.dart:1650:6)\n#39     _ElementDiagnosticableTreeNode.toJsonMap (package:flutter/src/widgets/framework.dart:5076:45)\n#40     WidgetInspectorService._getLayoutExplorerNode.<anonymous closure> (package:flutter/src/widgets/widget_inspector.dart:2065:61)\n#41     InspectorSerializationDelegate.additionalNodeProperties (package:flutter/src/widgets/widget_inspector.dart:3627:53)\n#42     DiagnosticsNode.toJsonMap.<anonymous closure> (package:flutter/src/foundation/diagnostics.dart:1635:21)\n#43     DiagnosticsNode.toJsonMap (package:flutter/src/foundation/diagnostics.dart:1650:6)\n...\n...\n#3263   _ElementDiagnosticableTreeNode.toJsonMap (package:flutter/src/widgets/framework.dart:5076:45)\n#3264   WidgetInspectorService._getLayoutExplorerNode.<anonymous closure> (package:flutter/src/widgets/widget_inspector.dart:2065:61)\n#3265   InspectorSerializationDelegate.additionalNodeProperties (package:flutter/src/widgets/widget_inspector.dart:3627:53)\n#3266   DiagnosticsNode.toJsonMap.<anonymous closure> (package:flutter/src/foundation/diagnostics.dart:1635:21)\n#3267   DiagnosticsNode.toJsonMap (package:flutter/src/foundation/diagnostics.dart:1650:6)\n#3268   _ElementDiagnosticableTreeNode.toJsonMap (package:flutter/src/widgets/framework.dart:5076:45)\n#3269   WidgetInspectorService._getLayoutExplorerNode.<anonymous closure> (package:flutter/src/widgets/widget_inspector.dart:2065:61)\n#3270   InspectorSerializationDelegate.additionalNodeProperties (package:flutter/src/widgets/widget_inspector.dart:3627:53)\n#3271   DiagnosticsNode.toJsonMap.<anonymous closure> (package:flutter/src/foundation/diagnostics.dart:1635:21)\n#3272   DiagnosticsNode.toJsonMap (package:flutter/src/foundation/diagnostics.dart:1650:6)\n#3273   _ElementDiagnosticableTreeNode.toJsonMap (package:flutter/src/widgets/framework.dart:5076:45)\n#3274   WidgetInspectorService._getLayoutExplorerNode.<anonymous closure> (package:flutter/src/widgets/widget_inspector.dart:2065:61)\n#3275   InspectorSerializationDelegate.additionalNodeProperties (package:flutter/src/widgets/widget_inspector.dart:3627:53)\n#3276   DiagnosticsNode.toJsonMap.<anonymous closure> (package:flutter/src/foundation/diagnostics.dart:1635:21)\n#3277   DiagnosticsNode.toJsonMap (package:flutter/src/foundation/diagnostics.dart:1650:6)\n#3278   _ElementDiagnosticableTreeNode.toJsonMap (package:flutter/src/widgets/framework.dart:5076:45)\n#3279   WidgetInspectorService._getLayoutExplorerNode.<anonymous closure> (package:flutter/src/widgets/widget_inspector.dart:2065:61)\n#3280   InspectorSerializationDelegate.additionalNodeProperties (package:flutter/src/widgets/widget_inspector.dart:3627:53)\n#3281   DiagnosticsNode.toJsonMap.<anonymous closure> (package:flutter/src/foundation/diagnostics.dart:1635:21)\n#3282   DiagnosticsNode.toJsonMap (package:flutter/src/foundation/diagnostics.dart:1650:6)\n#3283   _ElementDiagnosticableTreeNode.toJsonMap (package:flutter/src/widgets/framework.dart:5076:45)\n#3284   DiagnosticsNode.toJsonList.<anonymous closure> (package:flutter/src/foundation/diagnostics.dart:1675:19)\n#3285   new _GrowableList._ofEfficientLengthIterable (dart:core-patch/growable_array.dart:189:27)\n#3286   new _GrowableList.of (dart:core-patch/growable_array.dart:150:28)\n#3287   DiagnosticsNode.toJsonList (package:flutter/src/foundation/diagnostics.dart:1676:8)\n#3288   DiagnosticsNode.toJsonMap.<anonymous closure> (package:flutter/src/foundation/diagnostics.dart:1643:23)\n#3289   DiagnosticsNode.toJsonMap (package:flutter/src/foundation/diagnostics.dart:1650:6)\n#3290   _ElementDiagnosticableTreeNode.toJsonMap (package:flutter/src/widgets/framework.dart:5076:45)\n#3291   WidgetInspectorService._nodeToJson (package:flutter/src/widgets/widget_inspector.dart:1656:18)\n#3292   WidgetInspectorService._getLayoutExplorerNode (package:flutter/src/widgets/widget_inspector.dart:2037:14)\n#3293   BindingBase.registerServiceExtension.<anonymous closure> (package:flutter/src/foundation/binding.dart:953:32)\n#3294   _RootZone.runUnary (dart:async/zone.dart:1661:54)\n#3295   _FutureListener.handleValue (dart:async/future_impl.dart:156:18)\n#3296   Future._propagateToListeners.handleValueCallback (dart:async/future_impl.dart:840:45)\n#3297   Future._propagateToListeners (dart:async/future_impl.dart:869:13)\n#3298   Future._complete (dart:async/future_impl.dart:632:7)\n#3299   new Future.delayed.<anonymous closure> (dart:async/future.dart:424:16)\n#3300   Timer._createTimer.<anonymous closure> (dart:async-patch/timer_patch.dart:18:15)\n#3301   _Timer._runTimers (dart:isolate-patch/timer_impl.dart:398:19)\n#3302   _Timer._handleMessage (dart:isolate-patch/timer_impl.dart:429:5)\n#3303   _RawReceivePort._handleMessage (dart:isolate-patch/isolate_patch.dart:189:12)\n","method":"ext.flutter.inspector.getLayoutExplorerNode"}

@CoderDake CoderDake self-assigned this Jul 4, 2023
@CoderDake
Copy link
Contributor Author

Looking into this more it appears that this happens with flutter master and a normal single view app, so I will mark this as just a widget inspector bug in general.

To recreate this:

  • flutter create fresh_app
  • cd fresh_app
  • flutter run -d macos
  • Open Devtools
  • Turn on "Select Widget Mode"
  • In the widget tree select FloatingActionButton
  • You will notice the Layout Explorer doesn't update and after a little bit the stack overflow will occur.

@CoderDake CoderDake changed the title [Multi View]Issue while inspecting App bar and floating action button Issue while inspecting App bar and floating action button Jul 4, 2023
@CoderDake
Copy link
Contributor Author

Fixed by #5946

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant