Limit Network text view to 2^16 characters to prevent it from crashing #6254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CoderDake
requested review from
kenzieschmoll,
bkonyi and
a team
as code owners
|
I'm fine with this for now, but I think this warrants further investigation as to why it causes a hang. We shouldn't have an issue rendering 2^16 characters. Can you file an issue to follow up on this? |
bkonyi
reviewed
Aug 28, 2023
bkonyi
reviewed
Aug 28, 2023
| NetworkResponseViewType.text => Text( | ||
| responseBody, | ||
| // Using TextViewer fixes | ||
| // https://github.com/flutter/devtools/issues/5973 |
There was a problem hiding this comment.
The above issue should be closed when this PR lands, but I'd file a new issue for this as it's a bandaid fix if we don't know why we're seeing the hang in the first place.
There was a problem hiding this comment.
Created the following issues in response to this discussion:
bkonyi
approved these changes
Aug 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For images, the request and response bodies can get large which cause the Text view to hang DevTools.
I've hardcoded the 2^16 character limit for now, but I could be persuaded to allow an override in case other textviews have different needs.
Fixes #5973
Examples
Truncated
Under Character Limit