Make it clear that relative base hrefs are supported for the client/runtime if appropriately formed #11163
+6
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…untime if appropriately formed There are some places where a relative `base href` is not supported (and these are documented/validated), but there is nothing explicitly calling out that they are supported in the client app. This adds a note to solidify this so they can be used (for example in the DevTools server) without the worry of them being undocumented. Fixes flutter/flutter#154620
|
@mdebbar FYI! |
|
Visit the preview URL for this PR (updated for commit 5578f03): https://flutter-docs-prod--pr11163-clarify-base-href-abys28wt.web.app |
|
A direct link to the relevant part on the preview site is here: |
mdebbar
approved these changes
Sep 19, 2024
Co-authored-by: Mouad Debbar <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some places where a relative
base hrefis not supported (and these are documented/validated), but there is nothing explicitly calling out that they are supported in the client app. This adds a note to solidify this so they can be used (for example in the DevTools server) without the worry of them being undocumented.Fixes flutter/flutter#154620
Related:
base hrefsbase hrefs in DevTools serverPresubmit checklist
This PR is marked as draft with an explanation if not meant to land until a future stable release.