Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove dart:http as a dependency #89

Open
evaisse opened this issue May 21, 2024 · 1 comment
Open

Remove dart:http as a dependency #89

evaisse opened this issue May 21, 2024 · 1 comment

Comments

@evaisse
Copy link

evaisse commented May 21, 2024

Hello,

I need to update the dart:http package on my app, and I struggle to match the app_review http version dependency.

Don't you think it would be more reasonable to extract the http client from inside the app_review package and let user provide it on boot ? By giving an example in the documentation that would be a bit more tedious to implement but easier to maintain.

https://github.com/fluttercommunity/app_review/blob/master/lib/app_review.dart#L224

We could just add a Future Function() provider to the appreview constructor ?

And it's a breaking change for sure.

Thanks !

@victorandeloci
Copy link

i've removed the 1.1.0 version dependency in this fork: #90

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants