From 0ab874083265c289d6d843e05d95ce5bfe9d15ed Mon Sep 17 00:00:00 2001 From: Hidde Beydals Date: Mon, 21 Aug 2023 17:14:56 +0200 Subject: [PATCH 1/2] cmd: address typo in end-to-end tests Signed-off-by: Hidde Beydals --- cmd/flux/main_e2e_test.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/cmd/flux/main_e2e_test.go b/cmd/flux/main_e2e_test.go index 1cfa3acef2..008b810f87 100644 --- a/cmd/flux/main_e2e_test.go +++ b/cmd/flux/main_e2e_test.go @@ -41,7 +41,7 @@ func TestMain(m *testing.M) { // Install Flux. output, err := executeCommand("install --components-extra=image-reflector-controller,image-automation-controller") if err != nil { - panic(fmt.Errorf("install falied: %s error:'%w'", output, err)) + panic(fmt.Errorf("install failed: %s error:'%w'", output, err)) } // Run tests @@ -50,7 +50,7 @@ func TestMain(m *testing.M) { // Uninstall Flux output, err = executeCommand("uninstall -s --keep-namespace") if err != nil { - panic(fmt.Errorf("uninstall falied: %s error:'%w'", output, err)) + panic(fmt.Errorf("uninstall failed: %s error:'%w'", output, err)) } // Delete namespace and wait for finalisation From c03a0b7f87cb705a4976909a3bc6950514c7e8d7 Mon Sep 17 00:00:00 2001 From: Hidde Beydals Date: Mon, 21 Aug 2023 17:16:40 +0200 Subject: [PATCH 2/2] ci: disable fail-fast for ARM end-to-end Signed-off-by: Hidde Beydals --- .github/workflows/e2e-arm64.yaml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/e2e-arm64.yaml b/.github/workflows/e2e-arm64.yaml index e97fe17f48..92b3f91880 100644 --- a/.github/workflows/e2e-arm64.yaml +++ b/.github/workflows/e2e-arm64.yaml @@ -18,6 +18,7 @@ jobs: # Keep this list up-to-date with https://endoflife.date/kubernetes # Check which versions are available on DockerHub with 'crane ls kindest/node' KUBERNETES_VERSION: [ 1.25.11, 1.26.6, 1.27.3, 1.28.0 ] + fail-fast: false steps: - name: Checkout uses: actions/checkout@c85c95e3d7251135ab7dc9ce3241c5835cc595a9 # v3.5.3