Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drift mode should detect extra properties #896

Open
darkweaver87 opened this issue Feb 14, 2024 · 2 comments
Open

Drift mode should detect extra properties #896

darkweaver87 opened this issue Feb 14, 2024 · 2 comments

Comments

@darkweaver87
Copy link

Hello,

When drift mode is set either to warn or enabled, it should detect extra map keys and extra list objects.
For instance if an HelmRelease installs a Deployment with some environment variables set, it should detect this deployment has some manually added extra environment variables for instance and with correction enabled, remove those.

Thanks,

Rémi

@souleb
Copy link
Member

souleb commented Apr 17, 2024

As stated here, we compare object from the helm storage for a given release with existing versions in cluster. This is done using ssa dry-run, i.e. the kube-api server does it.
I believe that what you describe should already be implemented. Can you provide more details on your observation?

@hoerup
Copy link

hoerup commented Jun 17, 2024

(using flux 2.2.3 )

Just modified one of my Deployments which is installed via a HelmRelease and with driftmode enabled and added a dns override

spec:
  template:
    spec:
      hostAliases:
      - hostnames:
        - somehostname
        ip: 127.0.0.1

and this is not detected by flux

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants