Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle SvelteKit adapters properly #60

Open
endigma opened this issue Apr 23, 2024 · 1 comment
Open

Handle SvelteKit adapters properly #60

endigma opened this issue Apr 23, 2024 · 1 comment

Comments

@endigma
Copy link

endigma commented Apr 23, 2024

  • with SvelteKit using bun as the package manager and builder does not mean to use bun as the runner
  • the runner language is determined by the adapter, not the runtime used to build
  • I can use bun to build a nodejs output, and vice versa
  • and also: with adapter-static, it should use the nginx thing it does for astro

Stories:

  • Right now, if I launch a SvelteKit app that uses bun as its package manager but adapter-node as its runtime, it tries to run the node bundle with bun which won't work properly
  • Right now, if I launch a SvelteKit app that uses adapter-static, it assumes it's node/bun and runs it with that
  • Right now, the deno adapter and anything else probably is broken in a similar way
@rubys
Copy link
Contributor

rubys commented Apr 23, 2024

I can use bun to build a nodejs output, and vice versa

OK. But can we flip this around? Perhaps for svelte we should treat the adapter as authoritative? If @sveltejs/adapter-node is in package.json, then use node for everything. Similarly for svelte-adapter-bun, and perhaps even svelte-adapter-deno.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants