Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REDIS_PASSWORD isn't quoted correctly #3

Open
bkazez opened this issue Oct 19, 2021 · 4 comments
Open

REDIS_PASSWORD isn't quoted correctly #3

bkazez opened this issue Oct 19, 2021 · 4 comments

Comments

@bkazez
Copy link

bkazez commented Oct 19, 2021

I tried setting a REDIS_PASSWORD with special characters and I couldn't auth to the resulting server instance.

@rupurt
Copy link

rupurt commented Mar 3, 2022

@bkazez thank you for raising this issue! I could not figure out what was going on for the life of me

shymega added a commit to shymega/fly-apps-redis that referenced this issue Jan 2, 2024
This allows special characters to be used, fixing:
fly-apps#3

It will also ensure that the resulting server instance remains
accessible when the password has special characters.

Signed-off-by: Dom Rodriguez <[email protected]>
@shymega
Copy link

shymega commented Jan 2, 2024

@bkazez Could you try the branch I've just created, to see if that fixes your issue? Presuming I've understood it correctly.

Just a quick patch.

@bkazez
Copy link
Author

bkazez commented Jan 2, 2024

I've migrated the app to GKE and do not use fly anymore - sorry!

@shymega
Copy link

shymega commented Jan 2, 2024

@bkazez No worries. Fairly confident my branch will fix the issue.

shymega added a commit to shymega/fly-apps-redis that referenced this issue Jan 4, 2024
This allows special characters to be used, fixing:
fly-apps#3

It will also ensure that the resulting server instance remains
accessible when the password has special characters.

Had to double-quote the `redis-server` password argument, and escape the
double quotes in `PW_ARG`, to make sure it was assigned correctly.

Signed-off-by: Dom Rodriguez <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants