[BUG] TypeScript v5.5 breaks build

[ExampleWasTaken]

Description

A bug fix in TS v5.5 breaks our build.

It happens because discord.js export their own declarations for node:events. This causes TS to use those declarations instead of the ones from @types/node in src/lib/db.ts#L16. These types being incorrect fails the build.

At the moment we use TypeScript v5.3.3 which doesn't have the bug fix and therefore doesn't break our build.

Expected behavior

TypeScript should use the correct types at all times.

Steps to reproduce

1. Install the latest TypeScript version using

npm i -D typescript@latest

2. Run

npm run dev

Important

VSCode users, make sure you use the workspace typescript version as VSC uses its bundled TS version by default.

Note

Once done with testing, make sure to reset your workspace by running

git reset --hard & npm i

References

• Conflict between discord.js + @nodes/types after upgrading discordjs/discord.js#10358
• "Duplicate identifier" errors introduced in TS 5.5, if declare module is used microsoft/TypeScript#58961 (comment)

[alepouna]

Seems like d.js is patching it with this PR discordjs/discord.js#10360, once this is merged we can update d.js and it should be fine (?)

bug that became a feature for some, is now being patched 🤣

[ExampleWasTaken]

Seems like d.js is patching it with this PR discordjs/discord.js#10360, once this is merged we can update d.js and it should be fine (?)

bug that became a feature for some, is now being patched 🤣

Good spot! I'll subscribe to the PR and update our dependency once it's merged. (I hope it's that simple lol)

Feel free to assign me this issue :)

[ExampleWasTaken]

discordjs/discord.js#10360 has been merged, currently waiting on a new release from them

[ExampleWasTaken]

discord.js v14.16.0 has been released which includes the fix that's supposed to fix our issue.

I probably won't be able to work on it till the weekend though.