From 0692b2eaa33e4d58329d3ab84fb612381266f93e Mon Sep 17 00:00:00 2001 From: Yini Date: Tue, 19 Mar 2024 13:59:28 +0100 Subject: [PATCH] switch order of keys Signed-off-by: Yini --- ...es-keycloak-idp-flyteclients-without-browser.yaml | 6 +++--- charts/flyte-core/values.yaml | 6 +++--- docs/deployment/configuration/auth_setup.rst | 12 ++++++------ 3 files changed, 12 insertions(+), 12 deletions(-) diff --git a/charts/flyte-core/values-keycloak-idp-flyteclients-without-browser.yaml b/charts/flyte-core/values-keycloak-idp-flyteclients-without-browser.yaml index 2b55bb83f56..68dbeb594d4 100644 --- a/charts/flyte-core/values-keycloak-idp-flyteclients-without-browser.yaml +++ b/charts/flyte-core/values-keycloak-idp-flyteclients-without-browser.yaml @@ -298,13 +298,13 @@ deployRedoc: false secrets: adminOauthClientCredentials: - # If mount is true, helm will mount `flyte-secret-auth`. - # If mount is false, helm will not mount `flyte-secret-auth`. # If create is true, helm will create the `flyte-secret-auth`. # If create is false, it's up to the user to create `flyte-secret-auth` as described in # https://docs.flyte.org/en/latest/deployment/cluster_config/auth_setup.html#oauth2-authorization-server - mount: true + # If mount is true, helm will mount `flyte-secret-auth`. + # If mount is false, helm will not mount `flyte-secret-auth`. create: true + mount: true clientSecret: "<>" # put the secret for the confidential client flytepropeller defined in the IDP clientId: "flytepropeller" #use this client id and secret in the flytectl config with ClientSecret option diff --git a/charts/flyte-core/values.yaml b/charts/flyte-core/values.yaml index becda27de6b..bc4a621c31f 100755 --- a/charts/flyte-core/values.yaml +++ b/charts/flyte-core/values.yaml @@ -430,13 +430,13 @@ deployRedoc: false secrets: adminOauthClientCredentials: - # If mount is true, helm will mount `flyte-secret-auth`. - # If mount is false, helm will not mount `flyte-secret-auth`. # If create is true, helm will create the `flyte-secret-auth`. # If create is false, it's up to the user to create `flyte-secret-auth` as described in # https://docs.flyte.org/en/latest/deployment/cluster_config/auth_setup.html#oauth2-authorization-server - mount: true + # If mount is true, helm will mount `flyte-secret-auth`. + # If mount is false, helm will not mount `flyte-secret-auth`. create: true + mount: true clientSecret: foobar clientId: flytepropeller diff --git a/docs/deployment/configuration/auth_setup.rst b/docs/deployment/configuration/auth_setup.rst index b9f318fb778..026874650f1 100644 --- a/docs/deployment/configuration/auth_setup.rst +++ b/docs/deployment/configuration/auth_setup.rst @@ -345,13 +345,13 @@ Apply OIDC Configuration secrets: adminOauthClientCredentials: - # If mount is true, helm will mount `flyte-secret-auth`. - # If mount is false, helm will not mount `flyte-secret-auth`. # If create is true, helm will create the `flyte-secret-auth`. # If create is false, it's up to the user to create `flyte-secret-auth` as described in # https://docs.flyte.org/en/latest/deployment/cluster_config/auth_setup.html#oauth2-authorization-server - mount: true + # If mount is true, helm will mount `flyte-secret-auth`. + # If mount is false, helm will not mount `flyte-secret-auth`. create: true + mount: true # Use the non-encoded version of the random password clientSecret: "" clientId: flytepropeller @@ -601,8 +601,8 @@ Follow the steps in this section to configure `flyteadmin` to use an external au secrets: adminOauthClientCredentials: - mount: true create: true # see the section "Disable Helm secret management" if you require to do so + mount: true # Replace with the client_secret provided by your IdP for flytepropeller. clientSecret: # Replace with the client_id provided by provided by your IdP for flytepropeller. @@ -621,8 +621,8 @@ Follow the steps in this section to configure `flyteadmin` to use an external au secrets: adminOauthClientCredentials: - mount: true create: true + mount: true clientSecret: clientId: --- @@ -679,8 +679,8 @@ Alternatively, you can instruct Helm not to create and manage the secret for ``f secrets: adminOauthClientCredentials: - mount: true # mount the flyte-secret-auth secret to the flytepropeller. create: false # set to false + mount: true # mount the flyte-secret-auth secret to the flytepropeller. # Replace with the client_id provided by provided by your IdP for flytepropeller. clientId: