From 23d5fc20723f304418ac53c47c62f0980331c4f5 Mon Sep 17 00:00:00 2001 From: Yee Hing Tong Date: Mon, 30 Oct 2023 09:30:42 +0800 Subject: [PATCH] couple small items Signed-off-by: Yee Hing Tong --- flyteadmin/flyteadmin_config.yaml | 5 ++--- flyteadmin/pkg/async/cloudevent/implementations/sender.go | 3 --- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/flyteadmin/flyteadmin_config.yaml b/flyteadmin/flyteadmin_config.yaml index b42b742d68..6840b406cd 100644 --- a/flyteadmin/flyteadmin_config.yaml +++ b/flyteadmin/flyteadmin_config.yaml @@ -118,9 +118,8 @@ externalEvents: eventTypes: all cloudEvents: enable: true - type: redis - redis: - addr: "localhost:6379" + cloudEventVersion: v2 + type: sandbox Logger: show-source: true level: 5 diff --git a/flyteadmin/pkg/async/cloudevent/implementations/sender.go b/flyteadmin/pkg/async/cloudevent/implementations/sender.go index 87a552dd21..71d6a09a84 100644 --- a/flyteadmin/pkg/async/cloudevent/implementations/sender.go +++ b/flyteadmin/pkg/async/cloudevent/implementations/sender.go @@ -24,10 +24,7 @@ type PubSubSender struct { } func (s *PubSubSender) Send(ctx context.Context, notificationType string, event cloudevents.Event) error { - // gatepr: investigate why the previous statement didn't work. - // perhaps only because of redis. eventByte, err := pbcloudevents.Protobuf.Marshal(&event) - //eventByte, err := json.Marshal(&event) if err != nil { logger.Errorf(ctx, "Failed to marshal cloudevent with error: %v", err) return err