From 32539665b7a898b079970f8821048d8ed3426ffe Mon Sep 17 00:00:00 2001 From: Jeev B Date: Wed, 22 Nov 2023 16:33:20 -0800 Subject: [PATCH] PR comments --- flyteplugins/go/tasks/plugins/k8s/kfoperators/mpi/mpi.go | 4 ++-- .../go/tasks/plugins/k8s/kfoperators/pytorch/pytorch.go | 2 +- .../go/tasks/plugins/k8s/kfoperators/tensorflow/tensorflow.go | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/flyteplugins/go/tasks/plugins/k8s/kfoperators/mpi/mpi.go b/flyteplugins/go/tasks/plugins/k8s/kfoperators/mpi/mpi.go index 32aa26c556b..826e83b671c 100644 --- a/flyteplugins/go/tasks/plugins/k8s/kfoperators/mpi/mpi.go +++ b/flyteplugins/go/tasks/plugins/k8s/kfoperators/mpi/mpi.go @@ -126,10 +126,10 @@ func (mpiOperatorResourceHandler) BuildResource(ctx context.Context, taskCtx plu } if *workerReplicaSpec.Replicas <= 0 { - return nil, fmt.Errorf("number of worker should be more then 0") + return nil, fmt.Errorf("number of workers must be greater than 0") } if *launcherReplicaSpec.Replicas <= 0 { - return nil, fmt.Errorf("number of launch worker should be more then 0") + return nil, fmt.Errorf("number of launchers must be greater than 0") } jobSpec := kubeflowv1.MPIJobSpec{ diff --git a/flyteplugins/go/tasks/plugins/k8s/kfoperators/pytorch/pytorch.go b/flyteplugins/go/tasks/plugins/k8s/kfoperators/pytorch/pytorch.go index e04c15838c1..81c8e16cd56 100644 --- a/flyteplugins/go/tasks/plugins/k8s/kfoperators/pytorch/pytorch.go +++ b/flyteplugins/go/tasks/plugins/k8s/kfoperators/pytorch/pytorch.go @@ -113,7 +113,7 @@ func (pytorchOperatorResourceHandler) BuildResource(ctx context.Context, taskCtx } if *workerReplicaSpec.Replicas <= 0 { - return nil, fmt.Errorf("number of worker should be more then 0") + return nil, fmt.Errorf("number of workers must be greater than 0") } jobSpec := kubeflowv1.PyTorchJobSpec{ diff --git a/flyteplugins/go/tasks/plugins/k8s/kfoperators/tensorflow/tensorflow.go b/flyteplugins/go/tasks/plugins/k8s/kfoperators/tensorflow/tensorflow.go index cb9c6d5000b..eae56221288 100644 --- a/flyteplugins/go/tasks/plugins/k8s/kfoperators/tensorflow/tensorflow.go +++ b/flyteplugins/go/tasks/plugins/k8s/kfoperators/tensorflow/tensorflow.go @@ -120,7 +120,7 @@ func (tensorflowOperatorResourceHandler) BuildResource(ctx context.Context, task } if v, ok := replicaSpecMap[kubeflowv1.TFJobReplicaTypeWorker]; !ok || *v.Replicas <= 0 { - return nil, fmt.Errorf("number of worker should be more then 0") + return nil, fmt.Errorf("number of workers must be greater than 0") } jobSpec := kubeflowv1.TFJobSpec{