From cfc2f24befd6130ab297512ada2479a7675a6199 Mon Sep 17 00:00:00 2001 From: Jeev B Date: Tue, 21 Nov 2023 14:47:14 -0800 Subject: [PATCH] fixes Signed-off-by: Jeev B --- .../go/tasks/plugins/k8s/kfoperators/mpi/mpi_test.go | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/flyteplugins/go/tasks/plugins/k8s/kfoperators/mpi/mpi_test.go b/flyteplugins/go/tasks/plugins/k8s/kfoperators/mpi/mpi_test.go index f283dece94..fc570bf27d 100644 --- a/flyteplugins/go/tasks/plugins/k8s/kfoperators/mpi/mpi_test.go +++ b/flyteplugins/go/tasks/plugins/k8s/kfoperators/mpi/mpi_test.go @@ -339,12 +339,6 @@ func TestBuildResourceMPIForWrongInput(t *testing.T) { _, err := mpiResourceHandler.BuildResource(context.TODO(), dummyMPITaskContext(taskTemplate, resourceRequirements, nil)) assert.Error(t, err) - mpiObj = dummyMPICustomObj(1, 0, 1) - taskTemplate = dummyMPITaskTemplate(mpiID2, mpiObj) - - _, err = mpiResourceHandler.BuildResource(context.TODO(), dummyMPITaskContext(taskTemplate, resourceRequirements, nil)) - assert.Error(t, err) - mpiObj = dummyMPICustomObj(1, 1, 1) taskTemplate = dummyMPITaskTemplate(mpiID2, mpiObj) @@ -561,8 +555,8 @@ func TestReplicaCounts(t *testing.T) { contains []mpiOp.ReplicaType notContains []mpiOp.ReplicaType }{ - {"NoWorkers", 0, 1, true, nil, nil}, - {"NoLaunchers", 1, 0, true, nil, nil}, + {"NoWorkers", 1, 0, true, nil, nil}, + {"Minimum One Launcher", 0, 1, false, []mpiOp.ReplicaType{kubeflowv1.MPIJobReplicaTypeLauncher, kubeflowv1.MPIJobReplicaTypeWorker}, []mpiOp.ReplicaType{}}, {"Works", 1, 1, false, []mpiOp.ReplicaType{kubeflowv1.MPIJobReplicaTypeLauncher, kubeflowv1.MPIJobReplicaTypeWorker}, []mpiOp.ReplicaType{}}, } { t.Run(test.name, func(t *testing.T) {