Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Housekeeping] Refactor flyteadmin config handling #2293

Open
2 tasks done
katrogan opened this issue Mar 25, 2022 · 4 comments
Open
2 tasks done

[Housekeeping] Refactor flyteadmin config handling #2293

katrogan opened this issue Mar 25, 2022 · 4 comments
Assignees
Labels
flyteadmin Issue for FlyteAdmin Service housekeeping Issues that help maintain flyte and keep it tech-debt free

Comments

@katrogan
Copy link
Contributor

Describe the issue

The entire flyteadmin config handling, in the (note) poorly-named runtime folder is unnecessarily convoluted. Every top-level config block is accessed by a provider, which is an instance of an interface that is all injected as a singleton in the root service and makes the mockability of limited usefulness.

We should just abandon this complexity altogether. Define a config, call GetConfig in one place, and pass along config structs where necessary, instead of the providers, to preserve ease of unit testing.

What if we do not do this?

Adding new config fields continues to stay tedious, new contributors to flyteadmin will be rightfully confused and excess code/unnecessary abstractions usually slows down velocity

Related component(s)

flyteadmin

Are you sure this issue hasn't been raised already?

  • Yes

Have you read the Code of Conduct?

  • Yes
@katrogan katrogan added flyteadmin Issue for FlyteAdmin Service housekeeping Issues that help maintain flyte and keep it tech-debt free labels Mar 25, 2022
@katrogan katrogan self-assigned this Mar 25, 2022
@github-actions
Copy link

Hello 👋, This issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will close the issue if we detect no activity in the next 7 days. Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label Aug 29, 2023
@katrogan
Copy link
Contributor Author

(fighting the stalebot) we should keep this open :)

@github-actions github-actions bot removed the stale label Aug 30, 2023
Copy link

Hello 👋, this issue has been inactive for over 9 months. To help maintain a clean and focused backlog, we'll be marking this issue as stale and will engage on it to decide if it is still applicable.
Thank you for your contribution and understanding! 🙏

@github-actions github-actions bot added the stale label May 27, 2024
@katrogan
Copy link
Contributor Author

back here to counteract stalebot

@github-actions github-actions bot removed the stale label May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
flyteadmin Issue for FlyteAdmin Service housekeeping Issues that help maintain flyte and keep it tech-debt free
Projects
None yet
Development

No branches or pull requests

1 participant