[Housekeeping] Refactor flyteadmin config handling #2293
Labels
flyteadmin
Issue for FlyteAdmin Service
housekeeping
Issues that help maintain flyte and keep it tech-debt free
Describe the issue
The entire flyteadmin config handling, in the (note) poorly-named runtime folder is unnecessarily convoluted. Every top-level config block is accessed by a provider, which is an instance of an interface that is all injected as a singleton in the root service and makes the mockability of limited usefulness.
We should just abandon this complexity altogether. Define a config, call GetConfig in one place, and pass along config structs where necessary, instead of the providers, to preserve ease of unit testing.
What if we do not do this?
Adding new config fields continues to stay tedious, new contributors to flyteadmin will be rightfully confused and excess code/unnecessary abstractions usually slows down velocity
Related component(s)
flyteadmin
Are you sure this issue hasn't been raised already?
Have you read the Code of Conduct?
The text was updated successfully, but these errors were encountered: