Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

move the memverge doc from deployment/plugins to deployment/agent #4073

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

helenzhangyc
Copy link
Contributor

Tracking issue

Describe your changes

Moved the MemVerge doc from deployment/plugins to deployment/agent

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

@welcome
Copy link

welcome bot commented Sep 26, 2023

Thank you for opening this pull request! 🙌

These tips will help get your PR across the finish line:

  • Most of the repos have a PR template; if not, fill it out to the best of your knowledge.
  • Sign off your commits (Reference: DCO Guide).

rsts/deployment/agents/memverge/index.rst Outdated Show resolved Hide resolved
rsts/deployment/agents/memverge/index.rst Outdated Show resolved Hide resolved
rsts/deployment/plugins/index.rst Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.90%. Comparing base (8090b16) to head (2e6fb47).
Report is 958 commits behind head on master.

Current head 2e6fb47 differs from pull request most recent head 1d4ed64

Please upload reports for the commit 1d4ed64 to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4073      +/-   ##
==========================================
- Coverage   58.95%   58.90%   -0.06%     
==========================================
  Files         618      618              
  Lines       52676    52575     -101     
==========================================
- Hits        31057    30968      -89     
- Misses      19140    19142       +2     
+ Partials     2479     2465      -14     
Flag Coverage Δ
unittests 58.90% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

edwinyyyu and others added 7 commits September 26, 2023 11:56
Signed-off-by: Edwin Yu <[email protected]>
Signed-off-by: helenzhangyc <[email protected]>
Signed-off-by: helenzhangyc <[email protected]>
Signed-off-by: helenzhangyc <[email protected]>
Signed-off-by: helenzhangyc <[email protected]>
Signed-off-by: helenzhangyc <[email protected]>
rsts/deployment/agents/index.rst Outdated Show resolved Hide resolved
rsts/deployment/agents/memverge/mmcloud.rst Outdated Show resolved Hide resolved
helenzhangyc and others added 2 commits September 26, 2023 13:47
Co-authored-by: Kevin Su <[email protected]>
Signed-off-by: Helen Zhang <[email protected]>
@pingsutw
Copy link
Member

Actually, you don't need to create a folder for memverge agent. You could just add a memverge.rst under deployment/agents
image

@github-actions github-actions bot added the stale label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants