Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Add new page for jupyter notebook interactive mode #6036

Merged
merged 26 commits into from
Dec 20, 2024

Conversation

Mecoli1219
Copy link
Contributor

@Mecoli1219 Mecoli1219 commented Nov 20, 2024

Tracking issue

#5907

Screenshots

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

Important Note: We should revert the change of import_project in conf.py after this PR (flytesnacks#1754) is merged!

Docs link

https://flyte--6036.org.readthedocs.build/en/6036/user_guide/flyte_fundamentals/jupyter_notebook_interaction.html

Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.06%. Comparing base (b3330ba) to head (1d710e3).
Report is 59 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6036      +/-   ##
==========================================
+ Coverage   37.03%   37.06%   +0.03%     
==========================================
  Files        1313     1316       +3     
  Lines      131618   132178     +560     
==========================================
+ Hits        48745    48994     +249     
- Misses      78645    78922     +277     
- Partials     4228     4262      +34     
Flag Coverage Δ
unittests-datacatalog 51.58% <ø> (ø)
unittests-flyteadmin 54.10% <ø> (ø)
unittests-flytecopilot 22.23% <ø> (ø)
unittests-flytectl 62.46% <ø> (ø)
unittests-flyteidl 7.25% <ø> (ø)
unittests-flyteplugins 53.72% <ø> (+0.04%) ⬆️
unittests-flytepropeller 42.63% <ø> (-0.49%) ⬇️
unittests-flytestdlib 57.59% <ø> (+2.40%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
Signed-off-by: Mecoli1219 <[email protected]>
@Mecoli1219 Mecoli1219 marked this pull request as ready for review November 22, 2024 16:48
@Mecoli1219 Mecoli1219 requested a review from ppiegaze as a code owner November 22, 2024 16:48
@Mecoli1219 Mecoli1219 changed the title [WIP] [Docs] Add new page for jupyter notebook interactive mode [Docs] Add new page for jupyter notebook interactive mode Nov 22, 2024
@Mecoli1219
Copy link
Contributor Author

@samhita-alla @davidmirror-ops Please check this out! Thanks

@davidmirror-ops
Copy link
Contributor

@Mecoli1219 this is great. I guess we'll also need to update this to reference the flyte blog once it is out

@davidmirror-ops
Copy link
Contributor

@Mecoli1219 we'll merge this once flytekit 1.14 is out (1st week of December)

@Mecoli1219
Copy link
Contributor Author

Hi, @davidmirror-ops. Should this PR be merged?

@davidmirror-ops davidmirror-ops merged commit 27b2f3a into flyteorg:master Dec 20, 2024
52 checks passed
Copy link

welcome bot commented Dec 20, 2024

Congrats on merging your first pull request! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants