Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP][Flytekit] Add custom agent template in Pyflyte Init #51

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

[WIP][Flytekit] Add custom agent template in Pyflyte Init #51

wants to merge 8 commits into from

Conversation

mao3267
Copy link

@mao3267 mao3267 commented Dec 31, 2024 •
edited
Loading

Tracking issue

Closes flyteorg/flyte#6128

Why are the changes needed?

Users often encounter challenges while developing custom agents. To address this, we aim to provide support through a straightforward template that will help them quickly get on track.

What changes were proposed in this pull request?

  1. Added custom agent template for pyflyte init to fetch.
  2. Do local tests to make sure it works.

How was this patch tested?

  1. Run it on local machine. However, this can not be tested without modifying the template_zip_url and zip_root_name. You can temporarily set template_zip_url to https://github.com/mao3267/flytekit-python-template/archive/refs/heads/basic-custom-agent.zip and zip_root_name to flytekit-python-template-basic-custom-agent for testing.
pyflyte init --template custom-agent-template my_app

Setup process

git clone https://github.com/flyteorg/flytekit.git
gh pr checkout
pip install -e .

Screenshots

  • Run Pyflyte Init

image
image

  • Build Image
docker buildx build --platform linux/amd64 -t localhost:30000/flyteagent:custom-agent -f Dockerfile .
docker run -it localhost:30000/flyteagent:custom-agent

image

Check all the applicable boxes

  • I updated the documentation accordingly.
  • All new and existing tests passed.
  • All commits are signed-off.

Related PRs

None

Docs link

TODO

@welcome Welcome
Copy link

welcome bot commented Dec 31, 2024

Thank you for opening this pull request! 🙌
These tips will help get your PR across the finish line: - Most of the repos have a PR template; if not, fill it out to the best of your knowledge. - Sign off your commits (Reference: DCO Guide).

Future-Outlier
Future-Outlier reviewed Jan 2, 2025
View reviewed changes
Copy link
Member

@Future-Outlier Future-Outlier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very amazing, what do we need to push this now?

@mao3267
Copy link
Author

mao3267 commented Jan 3, 2025

@Future-Outlier You mentioned that some parts of the code for developing the agent are not finished. However, I thought this code was the same as what is referenced here. As a result, I am not sure if the current implementation addresses all the requirements we want for this template. If there are any additional details (instruction comments, tests, documents) we need to cover, please let me know.

@Future-Outlier
Copy link
Member

@Future-Outlier You mentioned that some parts of the code for developing the agent are not finished. However, I thought this code was the same as what is referenced here. As a result, I am not sure if the current implementation addresses all the requirements we want for this template. If there are any additional details (instruction comments, tests, documents) we need to cover, please let me know.

I want to add sync agent example, you can refer the chatgpt plugin
https://github.com/flyteorg/flytekit/blob/master/plugins/flytekit-openai/flytekitplugins/openai/chatgpt/agent.py#L20

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Future-Outlier Future-Outlier Future-Outlier left review comments

Assignees
No one assigned
Labels
None yet
Projects
OSS Contributions
Status: In progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Core feature] [Flytekit] Add Agent Template in Pyflyte Init
2 participants
@mao3267 @Future-Outlier