From 74b0a1b93a91c1fb05d5e8678fc46398d8864d7b Mon Sep 17 00:00:00 2001 From: Kevin Su Date: Tue, 5 Mar 2024 01:40:14 -0800 Subject: [PATCH] Update storage config in value-gcp.yaml Signed-off-by: Kevin Su --- charts/flyte-core/values-gcp.yaml | 16 +++++++++------- flytestdlib/storage/config.go | 2 +- 2 files changed, 10 insertions(+), 8 deletions(-) diff --git a/charts/flyte-core/values-gcp.yaml b/charts/flyte-core/values-gcp.yaml index 4051fb23b9..ea79b241ed 100644 --- a/charts/flyte-core/values-gcp.yaml +++ b/charts/flyte-core/values-gcp.yaml @@ -194,14 +194,16 @@ common: # storage: - # -- Sets the storage type. Supported values are sandbox, s3, gcs and custom. - type: gcs + # -- Sets the storage type. Supported values are s3/minio/local/mem/stow. + type: stow + stow: + kind: google + config: + json: "" + project_id: "{{ .Values.userSettings.googleProjectId }}" + scopes: https://www.googleapis.com/auth/cloud-platform # -- bucketName defines the storage bucket flyte will use. Required for all types except for sandbox. - bucketName: "{{ .Values.userSettings.bucketName }}" - # -- settings for storage type s3 - gcs: - # -- GCP project ID. Required for storage type gcs. - projectId: "{{ .Values.userSettings.googleProjectId }}" + container: "{{ .Values.userSettings.bucketName }}" db: datacatalog: diff --git a/flytestdlib/storage/config.go b/flytestdlib/storage/config.go index fc2f6f075d..36c05c8a7c 100644 --- a/flytestdlib/storage/config.go +++ b/flytestdlib/storage/config.go @@ -52,7 +52,7 @@ type Config struct { // Container here is misleading, it refers to a Bucket (AWS S3) like blobstore entity. In some terms it could be a table InitContainer string `json:"container" pflag:",Initial container (in s3 a bucket) to create -if it doesn't exist-.'"` - // By default if this is not enabled, multiple containers are not supported by the storage layer. Only the configured `container` InitContainer will be allowed to requests data from. But, if enabled then data will be loaded to written to any + // By default, if this is not enabled, multiple containers are not supported by the storage layer. Only the configured `container` InitContainer will be allowed to requests data from. But, if enabled then data will be loaded to written to any // container specified in the DataReference. MultiContainerEnabled bool `json:"enable-multicontainer" pflag:",If this is true, then the container argument is overlooked and redundant. This config will automatically open new connections to new containers/buckets as they are encountered"` // Caching is recommended to improve the performance of underlying systems. It caches the metadata and resolving