Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero Tokei #69

Closed
fmang opened this issue Feb 28, 2018 · 1 comment
Closed

Zero Tokei #69

fmang opened this issue Feb 28, 2018 · 1 comment
Assignees
Milestone

Comments

@fmang
Copy link
Owner

fmang commented Feb 28, 2018

To be honest, this is the actual reason behind #44. I like that song, and oshu 1.6.0 doesn't play it well, as proven by #56.

Now, 1.3.0 plays it well, so by bissecting I can figure what commit introduced the regression.

The test suite will ensure it won't happen again.

@fmang
Copy link
Owner Author

fmang commented Feb 28, 2018

And the culprit was 55423b0. git bisect rocks.

Fixed by cc709eb.

@fmang fmang closed this as completed Feb 28, 2018
@fmang fmang self-assigned this Feb 28, 2018
@fmang fmang added this to the 2.0 milestone Feb 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant