Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load backgrounds with ImageMagick #79

Closed
fmang opened this issue Jun 3, 2018 · 2 comments
Closed

Load backgrounds with ImageMagick #79

fmang opened this issue Jun 3, 2018 · 2 comments
Assignees

Comments

@fmang
Copy link
Owner

fmang commented Jun 3, 2018

The current background loader uses SDL_Image to decode the picture, and then Cairo to prescale it with a complex dance.

ImageMagick can do the job just fine, and more easily. We'll probably need ImageMagick sooner or later anyway with #78, so we might as well ditch SDL_Image while we're at it.

@fmang fmang self-assigned this Jun 3, 2018
@lanodan
Copy link
Contributor

lanodan commented Jun 3, 2018

I’d go against ImageMagick (same goes for GraphicsMagick) as it got quite a history of security issues and theses backgrounds aren’t from the user.
And it would introduce yet another dependency while ffmpeg or SDL are probably able to do it too (maybe with a bit more of work tho).

@fmang
Copy link
Owner Author

fmang commented Jun 3, 2018 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants