Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen mode #90

Open
Sur3 opened this issue Jun 12, 2020 · 2 comments
Open

Fullscreen mode #90

Sur3 opened this issue Jun 12, 2020 · 2 comments

Comments

@Sur3
Copy link

Sur3 commented Jun 12, 2020

Using alt+space window menu to get into the fullscreen mode is way to complicated.
There should be a command line option and maybe config file for starting in fullscreen mode. Also common key combinations like f or alt+enter for entering and leaving fullscreen seem not to work.

@fmang
Copy link
Owner

fmang commented Jun 12, 2020

You can change the default size by setting the environment variable OSHU_WINDOW_SIZE, but can’t currently enable full-screen on startup. Adding that feature sounds easy enough though.

I think most window managers have a keyboard shortcut to make a window full-screen, so it can probably get simpler than invoking your menu. Still, I can understand you’d like oshu to start full-screen directly.

@Sur3
Copy link
Author

Sur3 commented Jun 17, 2020

As I understand oshu is using SDL2 so toggling fullscreen mode could work similar to this:

if(fullscreen==0){ //enable window fullscreen mode
     SDL_SetWindowFullscreen(window,SDL_WINDOW_FULLSCREEN_DESKTOP);
     fullscreen=1; 
 }else if(fullscreen==1){ //disable fullscreen mode
     SDL_SetWindowFullscreen(window,0);
     fullscreen=0;
 }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants